Refactor rstests as tests#1080
Conversation
|
I will give it a shot if i find some time. |
|
That is certainly a tedious change to roll by hand. Going ahead with it should certainly current benefits into account instead of just the opinion of someone who doesn't spend their time anymore on this repo. On obvious downside is that the syntax for the case macros isn't the prettiest (but IMHO better than some of the |
|
I have been investigating the root for the rtests change: it traces back to @stormasm in #704, for two reasons (1) it seemed to be blocking Both look moot now. The So i would agree with @sholderbach's objections, no parallel running of tests, no ignored in test output, no per-case pass/fail and I am very sorry @ymcx since you definitely put a lot of work into this PR, but I would lean towards keeping |
As (shortly) discussed in #1078 and first introduced in #704 (comment).
Just like the title implies, this PR pretty much replaces all rstest unit tests along with their test cases with regular tests by manually iterating over all of the individual test cases one at a time.
Even though the refactor itself is quite simple and could easily have been and probably should have been automated, I did it completely by hand. I tried to keep all ignored test cases intact along with the comments if any, but I can't guarantee I didn't miss any. Other than that it should functionally match 1:1 to the previous behaviour.
I'm sorry for whoever has to go through the changelog as it's quite unreadable due to the sheer size of it.