-
Notifications
You must be signed in to change notification settings - Fork 22
feat: nupm registry subcommand
#122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
4d9d899
init commit
mkatychev 573100b
changed const
mkatychev 5409a71
get_index impl
mkatychev 3bcf1e9
removed TODOs for callout of registry subcommand
mkatychev 87ed5d1
Merge branch 'main' into feat/registry-submodule
mkatychev 26c3444
made nupm config declarative
mkatychev 67c2826
Merge branch 'main' into feat/registry-submodule
mkatychev fce3057
updated NUPM_ variables to match nested structure
mkatychev 354dc8e
typos
mkatychev 2efd004
updated initial test variables
mkatychev 5e96f1a
fixed registry typo
mkatychev 0821712
renamed tmp to temp
mkatychev 445be0f
revert temp
mkatychev 1f12490
fixed tmp-dir variable resolution issue
mkatychev f33f29e
updated with workaround
mkatychev 7d3a1cf
updated test cases for exitsting registry subcommands
mkatychev 12d95c1
initial naive registry describe impl
mkatychev fe5b26c
registry describe passing test
mkatychev 2907762
moved open-index to module root
mkatychev 11a7a38
removed log calls intest
mkatychev b054db3
update registry header comment
mkatychev aa12a95
update registry init shim
mkatychev d5d6699
partial test pass
mkatychev bac9659
all tests pass
mkatychev baaf4f4
revert test mod closuer
mkatychev 8542850
simplify variable setting
mkatychev af2a6ad
reverted nested nupm config
mkatychev 081677b
remove flaten-nupm-env
mkatychev 01b33b2
added registry_filename constants
mkatychev b2e85f2
removed fetch command
mkatychev 4c55581
remoted editorconfig
mkatychev 102d970
PR feedback on addtion of registry values
mkatychev 78848fe
revert README
mkatychev 919865b
updated formatting messages
mkatychev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| # Registry management for nupm | ||
|
|
||
| use utils/dirs.nu [nupm-home-prompt] | ||
| use utils/log.nu throw-error | ||
|
|
||
| # Show information about configured registries | ||
| @example "List all configured registries" { nupm registry } | ||
| export def main []: nothing -> table { | ||
| list | ||
| } | ||
|
|
||
| # List all configured registries | ||
| @example "List all registries with details" { nupm registry list } | ||
| export def list []: nothing -> table { | ||
| $env.nupm.registries | transpose name url | sort-by name | ||
| } | ||
|
|
||
|
|
||
| # TODO | ||
| # Show detailed information about a specific registry | ||
| # @example "Show registry information" { nupm registry describe nupm } | ||
| # export def describe [ | ||
| # name: string # Name of the registry | ||
| # ]: nothing -> table { | ||
| # } | ||
|
|
||
| # Add a new registry | ||
| @example "Add a new registry" { nupm registry add my-registry https://example.com/registry.nuon } | ||
| export def --env add [ | ||
| name: string, # Name of the registry | ||
| url: string, # URL or path to the registry | ||
| --save, # Whether to commit the change to the registry index | ||
| ] { | ||
| if ($name in $env.nupm.registries) { | ||
| throw-error $"Registry '($name)' already exists. Use 'nupm registry update' to modify it." | ||
| } | ||
| $env.nupm.registries = $env.nupm.registries | insert $name $url | ||
|
|
||
| if $save { | ||
| $env.nupm.registries | save --force $env.nupm.index-path | ||
| } | ||
|
|
||
| print $"Registry '($name)' added successfully." | ||
| } | ||
|
|
||
| # Remove a registry | ||
| @example "Remove a registry" { nupm registry remove my-registry } | ||
| export def --env remove [ | ||
| name: string # Name of the registry to remove | ||
| --save, # Whether to commit the change to the registry index | ||
| ] { | ||
| $env.nupm.registries = $env.nupm.registries | reject $name | ||
|
|
||
| if $save { | ||
| $env.nupm.registries | save --force $env.nupm.index-path | ||
| } | ||
|
|
||
| print $"Registry '($name)' removed successfully." | ||
| } | ||
|
|
||
| # Update a given registry url | ||
| @example "Update registry URL" { nupm registry set-url my-registry https://new-url.com/registry.nuon } | ||
| export def --env set-url [ | ||
| name: string, # Name of the registry to update | ||
| url: string, | ||
| --save, # Whether to commit the change to the registry index | ||
| ]: nothing -> nothing { | ||
| $env.nupm.registries = $env.nupm.registries | update $name $url | ||
|
|
||
| if $save { | ||
| $env.nupm.registries | save --force $env.nupm.index-path | ||
| } | ||
|
|
||
| print $"Registry '($name)' URL updated successfully." | ||
| } | ||
|
|
||
| # Rename a registry | ||
| @example "Rename a registry" { nupm registry rename my-registry our-registry } | ||
| export def --env rename [ | ||
| name: string, # Name of the registry to update | ||
| new_name: string, | ||
| --save, # Whether to commit the change to the registry index | ||
| ] { | ||
| $env.nupm.registries = $env.nupm.registries | ^rename --column { $name: $new_name } | ||
|
|
||
| if $save { | ||
| $env.nupm.registries | save --force $env.nupm.index-path | ||
| } | ||
|
|
||
| print $"Registry '($name)' renamed successfully." | ||
| } | ||
|
|
||
|
|
||
| # Initialize registry_idx.nuon with default registries | ||
| @example "Initialize registry list" { nupm registry init-index } | ||
| export def init-index [ | ||
|
|
||
| registry?: record<name: string, url: string, enabled: bool> | ||
| ] { | ||
| if not (nupm-home-prompt) { | ||
| throw-error "Cannot create nupm.home directory." | ||
| } | ||
|
|
||
| let registry_idx_path = $env.nupm.home | path join "registry_idx.nuon" | ||
|
|
||
| if ($registry_idx_path | path exists) { | ||
| print $"Registry list already exists at ($registry_idx_path)" | ||
| return | ||
| } | ||
|
|
||
| # Initialize with the default nupm registry | ||
| let default_registries = [ | ||
| { | ||
| name: "nupm", | ||
| url: "https://raw.githubusercontent.com/nushell/nupm/main/registry/registry.nuon", | ||
| enabled: true | ||
| } | ||
| ] | ||
|
|
||
| $default_registries | save $registry_idx_path | ||
|
|
||
| print $"Registry list initialized at ($registry_idx_path)" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| export def complete-registries [] { | ||
| $env.NUPM_REGISTRIES? | default {} | columns | ||
| $env.nupm.registries? | default {} | columns | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.