Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run tests
run: bundle exec rake test
- name: Annotate uncovered lines
uses: ggilder/codecoverage@v1
uses: ggilder/codecoverage@6a0a9c002c49b6e5e4ce15f22574275600163618

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this specific commit: See the discussion in ggilder/codecoverage#20. This commit changes a way of how action comment the warnings to annotations-via-console. Writing coverage annotations directly to the console avoids the API call, which in turn lets the workflow run with the default GITHUB_TOKEN (no repository write permission)

Current GitHub annotation limits

  • 10 warnings + 10 errors per step
  • 50 annotations per job (sum of all steps)
  • 50 “run” annotations (system-generated)

If we ever need more than those limits, we can pin the action to a tag that re-enables the API path—at the cost of requiring the checks: write permission again.

if: github.event_name == 'pull_request' && matrix.ruby == '3.4'
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down