Support for range size predicate - #18
Merged
Merged
Conversation
numbata
requested changes
Dec 21, 2025
numbata
left a comment
numbata
left a comment
Owner
There was a problem hiding this comment.
Overall this is a nice, tight improvement! Thanks for adding range support for size?.
One blocker: exclusive ranges map incorrectly to OpenAPI’s inclusive maxItems/maxLength (e.g., 3...5 emits max_size = 5, allowing 5 items). Please adjust to respect exclusivity (using rng.max is a clean fix) and add a test for the exclusive case
alongside the new inclusive one to lock the behavior. Once that’s in, I’m good.
P.S.: don’t forget to add a line in CHANGELOG.
slbug
force-pushed
the
array_size_range_support
branch
4 times, most recently
from
December 21, 2025 21:32
e640305 to
aaa6fa6
Compare
Owner
|
🚀 |
Owner
|
I fixed the RuboCop offense and temporarily disabled the memory profiler workflow on main branch. |
slbug
force-pushed
the
array_size_range_support
branch
from
December 21, 2025 21:44
aaa6fa6 to
8677911
Compare
numbata
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #17