Fix --outdir to pass a str to webbrowser.open_new_tab()#171
Closed
hugovk wants to merge 2 commits intonschloe:mainfrom
Closed
Fix --outdir to pass a str to webbrowser.open_new_tab()#171hugovk wants to merge 2 commits intonschloe:mainfrom
--outdir to pass a str to webbrowser.open_new_tab()#171hugovk wants to merge 2 commits intonschloe:mainfrom
Conversation
4f232eb to
7514dba
Compare
Owner
|
Can't resolve the diff (changes in main are large), but I'll make sure this works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because
webbrowser.open_new_tab(url)expectsurlto be astr, not apathlib.Path.Also remove some redundant parentheses.