Skip to content

Allow removal of tags with --force-cv #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jneidel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow removal of tags with --force-cv #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bab6c52
Allow removal of tags not in controlled vocabulary with --force-cv
jneidel Feb 20, 2026
69fb44c
Update dired usage example
jneidel Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Integration.org
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ An alternative implementation using the kitty terminal:
"Run \"filetags\" on current or marked files"
(interactive)
(dired-do-shell-command
"kitty -o remember_window_size=no -o initial_window_width=60c -o initial_window_height=15c --position 535x300 -o window_padding_width='0 20 0 20' --title floating -- filetags -q --interactive *"
"kitty -o remember_window_size=no -o initial_window_width=60c -o initial_window_height=15c --position 535x300 -o window_padding_width='0 20 0 20' --title floating -- filetags -q --force-cv --interactive *"
nil
(dired-get-marked-files))
(revert-buffer nil t t))
Expand Down
4 changes: 2 additions & 2 deletions filetags/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1652,9 +1652,9 @@ def get_invalid_tags_for_vocabulary(tags, vocabulary):

invalid_tags = []
for raw_tag in tags:
tag = raw_tag[1:] if raw_tag.startswith('-') else raw_tag
if raw_tag.startswith('-') and tag in normalized_vocabulary:
if raw_tag.startswith('-'): # always allow removals
continue
tag = raw_tag
if tag not in normalized_vocabulary:
invalid_tags.append(raw_tag)
return list(dict.fromkeys(invalid_tags))
Expand Down
2 changes: 1 addition & 1 deletion tests/unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def test_get_invalid_tags_for_vocabulary(self):
vocabulary = ['foo', 'bar', 'baz']
self.assertEqual(filetags.get_invalid_tags_for_vocabulary(['foo', 'bar'], vocabulary), [])
self.assertEqual(filetags.get_invalid_tags_for_vocabulary(['foo', 'qux'], vocabulary), ['qux'])
self.assertEqual(filetags.get_invalid_tags_for_vocabulary(['-foo', '-qux'], vocabulary), ['-qux'])
self.assertEqual(filetags.get_invalid_tags_for_vocabulary(['-foo', '-qux'], vocabulary), [])
self.assertEqual(filetags.get_invalid_tags_for_vocabulary(['aa', 'aa', 'bb', 'aa'], ['bb']), ['aa'])

def test_build_similar_to_invalid_tags_message(self):
Expand Down
Loading