Repository navigation
Monkeypatch negotiate to forward session-affinity cookies - #140
Open
MagneIngvaldsen wants to merge 1 commit into
Open
MagneIngvaldsen wants to merge 1 commit into
MagneIngvaldsen wants to merge 1 commit into
Conversation
MagneIngvaldsen
force-pushed
the
fix/negotiate-cookie-monkeypatch
branch
from
September 21, 2026 07:21
98310a2 to
57246a7
Compare
Collaborator
|
There seems to be some activity on pysignalr to change dependencies to "websockets>=15.0.1,<18" baking-bad/pysignalr#50 |
Author
|
Sure, if you can upgrade to a version with the fix no need for this PR |
|
Hey! Yeah, I saw this ticket and thought "why not, costs nothing". @olalid, could I cast you for testing and review when that PR (ws 15-18 support) will left the draft state? I don't have real API targets to test against. |
Collaborator
|
Yes, I will be happy to test, thanks @droserasprout. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pysignalr doesn't forward cookies from the negotiate response to the WS handshake, so connections behind a load balancer using cookie-based session affinity fail with "No Connection with that ID". Same fix as baking-bad/pysignalr#49, monkeypatched here the same way
easee.pyalready patches pysignalr's__aiter__.Tested against the real Easee streaming API: 3/8 negotiate attempts succeeded before this patch, 8/8 after.
Related: #139