Skip to content

Remove unused func and unnecessary shim#5053

Merged
mcollina merged 1 commit intomainfrom
remove-unused-func
Apr 17, 2026
Merged

Remove unused func and unnecessary shim#5053
mcollina merged 1 commit intomainfrom
remove-unused-func

Conversation

@tsctx
Copy link
Copy Markdown
Member

@tsctx tsctx commented Apr 17, 2026

I have removed unused and unreachable code paths.
The shim for WebSocket crypto.randomFillSync is no longer required since SHA-1 (essential for WebSocket functionality) cannot be used in environments without crypto support.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.10%. Comparing base (a516f87) to head (2d75925).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5053      +/-   ##
==========================================
+ Coverage   93.08%   93.10%   +0.02%     
==========================================
  Files         110      110              
  Lines       35804    35775      -29     
==========================================
- Hits        33327    33308      -19     
+ Misses       2477     2467      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a1d6766 into main Apr 17, 2026
36 checks passed
@mcollina mcollina deleted the remove-unused-func branch April 17, 2026 15:45
@github-actions github-actions Bot mentioned this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants