fix: preserve Request signal abort propagation after GC#4984
Draft
fix: preserve Request signal abort propagation after GC#4984
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4984 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 110 110
Lines 35773 35680 -93
=======================================
- Hits 33252 33166 -86
+ Misses 2521 2514 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Requestsignal following so abort propagation still works after GC pressure.This replaces the custom
WeakRef/FinalizationRegistry-based follow logic inlib/web/fetch/request.jswithAbortSignal.any([signal]).Changes
AbortSignal.any([signal])to create dependent request signalsRequestsignal surviving GC pressureRequestsignals surviving GC pressureMotivation
This reproduces the behavior discussed in:
The old implementation could disconnect
request.signalfrom its parent signal once the originalRequestobject became unreachable. As a result, aborting the parent signal no longer aborted the dependent request signal.Testing
NODE_OPTIONS=--expose-gc node --test test/fetch/request.jsNODE_OPTIONS=--expose-gc node --test test/fetch/long-lived-abort-controller.js test/node-fetch/request.js test/fetch/abort.js