doc: Update dump({ limit: Integer }) default value#4981
Merged
metcoder95 merged 1 commit intonodejs:mainfrom Apr 7, 2026
Merged
doc: Update dump({ limit: Integer }) default value#4981metcoder95 merged 1 commit intonodejs:mainfrom
dump({ limit: Integer }) default value#4981metcoder95 merged 1 commit intonodejs:mainfrom
Conversation
samuel871211
commented
Apr 6, 2026
| `body` contains the following additional extensions: | ||
|
|
||
| - `dump({ limit: Integer })`, dump the response by reading up to `limit` bytes without killing the socket (optional) - Default: 262144. | ||
| - `dump({ limit: Integer })`, dump the response by reading up to `limit` bytes without killing the socket (optional) - Default: 131072. |
Contributor
Author
There was a problem hiding this comment.
https://github.com/nodejs/undici/blob/main/lib/api/readable.js#L274
const limit = opts?.limit && Number.isFinite(opts.limit)
? opts.limit
: 128 * 1024
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4981 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 110 110
Lines 35773 35773
=======================================
Hits 33252 33252
Misses 2521 2521 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status