Merged
Conversation
Contributor
Checklist
|
sbreitbart-NOAA
requested changes
Mar 18, 2026
Collaborator
sbreitbart-NOAA
left a comment
sbreitbart-NOAA
left a comment
There was a problem hiding this comment.
Thanks for getting this started! I think a few steps are needed to adapt this code for use within asar (see my comments). Running devtools::document() will also highlight some areas where changes are needed to merge this into asar
Collaborator
Author
|
@sbreitbart-NOAA Thanks for the review. I didn't even consider having to add in fxns from utils that aren't exported from the package. We might be able to get away with calling them using the :::, so I will try that. If that does not work, then I think we need to scrap this idea because copying in the utility functions can get squirrely and I don't want to have all of this content to remove as well. |
Collaborator
sbreitbart-NOAA
left a comment
sbreitbart-NOAA
left a comment
There was a problem hiding this comment.
This is working now! Thanks also for updating the documentation. I think this is good to merge with a few minor wording changes and once the instances of gt::gt_split() are changed to asar::gt_split().
Schiano-NOAA
force-pushed
the
add-gt-split
branch
from
5b82c16 to
5869908
Compare
sbreitbart-NOAA
added a commit
that referenced
this pull request
Mar 27, 2026
* Update a11y guide with info about how to escape special characters in alt text/captions csv * Update readme example create_template() arg from 'author' to 'authors' * Update ID_tbl_width_class() to work with gt tables, vs flextables * Update create_tables_doc() and related functions so begin replacing flextable-based pipeline with gt (for identifying table width, and splitting/rotating where needed). Next step: split super-long tables where necessary * create new function to get table length; update documentation * Redesign tables doc workflow to work with >1 tables shown on portrait orientation and 1 table shown on landscape orientation * Redesign tables doc workflow to work with >1 table shown on landscape orientation * Redesign tables doc workflow to work with remaining types of tables * update tests by removing flextable and replacing with gt * sub flextable with gt in DESCRIPTION and devcontainer * create tests for ID_tbl_length_class() * Update tests * Update captions for split tables by removing individual column names shown, and instead state number of table vs total number of tables * Update render_lg_table() to work with varying essential column values, and redesign to better work with gt tables vs flextables; update documentation and tests * Delete unusable, duplicated license * Address warnings in R cmd check * Comment out code that restricts table column width unnecessarily, since tab_options(table.width) is sufficient; add "tbl-pos: 't'" to table chunk options to anchor tables * Edit add_child() to add line to tables chunk in skeleton to add "clearpage" latex command * Update captions for tables split by columns to remove mention of specific columns in the table * Set col widths for tables; fix issue with extra-wide tables * Add missing pipes to create_tables_doc() * add gt_split into utils (#433) * add gt_split into utils * remove header from gt and add function dependencies in gt_split * update documentation for gt_split in export * update create_tables_doc to reference asar::gt_split and not gt --------- Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com>
Schiano-NOAA
added a commit
that referenced
this pull request
Mar 27, 2026
* Update "ESP" meaning in glossary as per #423 * update cheatsheet to remove 'withr()' wrapper from add_a11y function (#424) * Update special characters in glossary (#425) * Update glossary so that meanings with underscores have backslash to escape underscore * Update glossary so that meanings and acronyms have backslashes to escape special characters, and underscores in labels are converted to hyphens * Update glossary so that underscores and parentheses in labels are converted to hyphens * update affiliation with duplicate city for afsc seattle offices (#426) * Update preamble prompt (#430) * Update prompt about preamble as per #416 (comment) * Update prompt about preamble to exactly match suggestion in #416 (comment) * Update SAFE template table structure from flextable to asar (#432) * Update a11y guide with info about how to escape special characters in alt text/captions csv * Update readme example create_template() arg from 'author' to 'authors' * Update SAFE template table structure from flextable to asar as per #428 * Update functions that relied on 'flextable' and convert to 'gt' (#429) * Update a11y guide with info about how to escape special characters in alt text/captions csv * Update readme example create_template() arg from 'author' to 'authors' * Update ID_tbl_width_class() to work with gt tables, vs flextables * Update create_tables_doc() and related functions so begin replacing flextable-based pipeline with gt (for identifying table width, and splitting/rotating where needed). Next step: split super-long tables where necessary * create new function to get table length; update documentation * Redesign tables doc workflow to work with >1 tables shown on portrait orientation and 1 table shown on landscape orientation * Redesign tables doc workflow to work with >1 table shown on landscape orientation * Redesign tables doc workflow to work with remaining types of tables * update tests by removing flextable and replacing with gt * sub flextable with gt in DESCRIPTION and devcontainer * create tests for ID_tbl_length_class() * Update tests * Update captions for split tables by removing individual column names shown, and instead state number of table vs total number of tables * Update render_lg_table() to work with varying essential column values, and redesign to better work with gt tables vs flextables; update documentation and tests * Delete unusable, duplicated license * Address warnings in R cmd check * Comment out code that restricts table column width unnecessarily, since tab_options(table.width) is sufficient; add "tbl-pos: 't'" to table chunk options to anchor tables * Edit add_child() to add line to tables chunk in skeleton to add "clearpage" latex command * Update captions for tables split by columns to remove mention of specific columns in the table * Set col widths for tables; fix issue with extra-wide tables * Add missing pipes to create_tables_doc() * add gt_split into utils (#433) * add gt_split into utils * remove header from gt and add function dependencies in gt_split * update documentation for gt_split in export * update create_tables_doc to reference asar::gt_split and not gt --------- Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com> * Fix typo and update WORDLIST * Allow messages about tables when running create_template() (#431) * Update a11y guide with info about how to escape special characters in alt text/captions csv * Update readme example create_template() arg from 'author' to 'authors' * Allow messages in create_template() stating if tables aren't found, and how to make them, to match messaging produced for figures * add float package to in-header tex (#427) * update documentation * Comment out tests that should pass once nmfs-ost/stockplotr#205 is merged * change action so only comments when the PR is first opened (#435) * update version in pkg and cheatsheet * fix date in cheatsheet * Add missing leading zeroes back to affiliation zip codes --------- Co-authored-by: sbreitbart-NOAA <sophie.breitbart@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
gt_splitfunction from thegtpackage into asar that includes the fix for the functionHow have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?