Repository navigation
fix(terminal-types): handle user-pinned Pi sessions and explicit type selection - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two regressions observed when using a custom default terminal type pinned to
userauth.typeIdinPOST /api/sessionsso selecting built-interminalworks even when another type is the configured defaultDATABRICKS_TOKEN.databrickscfgusing token auth when running in user-token modeProblem
terminalin the picker still created the default custom type, because the frontend omittedtypeIdwhenterminalwas selected.authPolicy=userfailed bootstrap with:Missing DATABRICKS_CLIENT_IDMissing DATABRICKS_CLIENT_SECRETValidation
npm run checknpm testnpm run build