Test: Fix solarish_tap test on big-endian targets#2743
Conversation
|
Check i686-unknown-linux-musl failing due to unrelated reason:
|
asomers
left a comment
There was a problem hiding this comment.
The test change looks good. But I request that you remove the changelog entry. This change isn't visible to our crate's consumers, so it doesn't need to be mentioned in the changelog.
5d78bde to
06c2459
Compare
@asomers Changelog entry removed. |
06c2459 to
9e08e05
Compare
|
I rebased your branch to resolve the CI failures. |
What does this PR do
This change corrects the solarish_tap test on big-endian Solaris targets.
The two changes are to populate multi-byte numbers in the byte array using the native endianness (previous code assumed little-endianness), and to use a buffer that guarantees the required alignment when taking a pointer to it (previous code guaranteed only 1-byte alignment).
Tested on Solaris 11.4 (SPARC 64-bit).
Checklist:
CONTRIBUTING.md