refactor to_exec_array#2711
Draft
xtqqczze wants to merge 2 commits into
Draft
Conversation
xtqqczze
force-pushed
the
to_exec_array
branch
2 times, most recently
from
c2001f4 to
61c4513
Compare
xtqqczze
force-pushed
the
to_exec_array
branch
from
61c4513 to
c49d22e
Compare
match the other implemention in: https://github.com/nix-rust/nix/blob/71f6ee9f4380d5caad3c049dbd352627b9d6eb0a/src/unistd.rs#L1082-L1088
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the existing implementation in
src/spawn.rsresults in a possible unnecessary allocationuse a common optimised implementation