MAINT: Finalize migration of visual interfaces and reports to nireports#1034
MAINT: Finalize migration of visual interfaces and reports to nireports#1034oesteban wants to merge 7 commits into
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12b56c3dce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'Niworkflows will be deprecating visualizations in favor of a standalone library "nireports".' | ||
| from .._deprecated import raise_moved_to_nireports | ||
|
|
||
| raise_moved_to_nireports( |
There was a problem hiding this comment.
Raising DeprecationError unconditionally in niworkflows.viz.__init__ prevents any niworkflows.viz.<submodule> import from reaching its own module-level deprecation handler, because Python imports the package initializer before loading submodules. In practice, import niworkflows.viz.utils/plots/notebook will always fail here and never show the symbol-specific replacement hints defined in those files, which makes migration guidance incomplete for many existing imports.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
- Coverage 67.13% 66.21% -0.93%
==========================================
Files 54 55 +1
Lines 6849 5416 -1433
Branches 852 655 -197
==========================================
- Hits 4598 3586 -1012
+ Misses 2036 1689 -347
+ Partials 215 141 -74 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Supersedes #789.
I had to add nireports as a dependency: some *RPT interfaces (e.g., some about ANTS) were not ported, and I think it's because they would trigger a chain effect requiring heavy sections of code to be ported or duplicated with them.