[FIX] Entity order for derivatives data sink#1020
Open
bendhouseart wants to merge 7 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1020 +/- ##
==========================================
- Coverage 71.77% 67.13% -4.65%
==========================================
Files 91 54 -37
Lines 8755 6849 -1906
Branches 936 852 -84
==========================================
- Hits 6284 4598 -1686
+ Misses 2238 2036 -202
+ Partials 233 215 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oesteban
reviewed
Feb 22, 2026
| "sub-{subject}[/ses-{session}]/{datatype<anat>|anat}/sub-{subject}[_ses-{session}][_hash-{hash}][_acq-{acquisition}][_ce-{ceagent}][_rec-{reconstruction}][_run-{run}][_space-{space}][_cohort-{cohort}][_res-{resolution}]_label-{label}[_desc-{desc}]_{suffix<probseg>|probseg}{extension<.nii|.nii.gz|.json>|.nii.gz}", | ||
| "sub-{subject}[/ses-{session}]/{datatype<anat>|anat}/sub-{subject}[_ses-{session}][_hash-{hash}][_desc-{desc}]_{suffix<dseg>}{extension<.tsv|.json>|.tsv}", | ||
| "sub-{subject}[/ses-{session}]/{datatype<anat>|anat}/sub-{subject}[_ses-{session}][_hash-{hash}][_label-{label}][_desc-{desc}]_{suffix<morph>}{extension<.tsv|.json>|.tsv}", | ||
| "sub-{subject}[/ses-{session}]/{datatype<anat>|anat}/sub-{subject}[_ses-{session}][_hash-{hash}][_acq-{acquisition}][_ce-{ceagent}][_rec-{reconstruction}][_run-{run}]_hemi-{hemi<L|R>}[_space-{space}][_cohort-{cohort}][_den-{density}]_desc-{desc}_{suffix<mask>|mask}{extension<.label.gii|.json>|.label.gii}", |
oesteban
changed the title
bendhouseart
changed the title
bendhouseart
marked this pull request as draft
February 23, 2026 14:16
bendhouseart
marked this pull request as ready for review
February 24, 2026 16:24
bendhouseart
changed the title
Author
|
Okay, it think it could use 1 more sort according to schema.rules.entities, but before I do that, where should If not then I think it would best belong before Also, efforts are underway with pybids to help avoid ever having to do this manually again. |
Member
|
hash should stay where it is, after session. @mgxd added it to allow for use in a BIDS-adjacent database context, so we should not mess with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #1018, this is the easier path to fix this. Only updates the entities touched by petprep. Please feel free to request/push changes to update other file name templates.