feat(effect): consolidate effect utilities into one - #703
Open
XavierDupessey wants to merge 1 commit into
Open
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
XavierDupessey
force-pushed
the
feature-effect
branch
from
July 31, 2026 09:21
79c0fce to
12c1bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
ngextensionscurrently contains several utilities built around effects, such asexplicitEffect,effectOnceIf, reactiveon, and possibly others.I'd like to get your feedback on introducing a single
effectutility that could cover all of these use cases.To demonstrate the idea, I updated the existing unit tests for those utilities to use the new implementation instead. This should make it easier to compare the different APIs and see how they translate to the proposed one.
Some characteristics of the new utility:
deferoption).filteroption).onceoption).I'm curious to hear your thoughts. Any feedback, suggestions, or concerns are very welcome! 🙂