Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ describe(injectRouteFragment.name, () => {
expect(instance.numberFragmentDefaultValue()).toEqual(100000000);
});

it('returns a falsy default value instead of falling back to null', async () => {
const instance = await harness.navigateByUrl('test', TestComponent);

// defaultValue: 0 is a legitimate falsy default and should be
// returned as-is when there is no fragment, not discarded for `null`
expect(instance.zeroFragmentDefaultValue()).toEqual(0);
});

it('returns right signals and values for different parsers', async () => {
const instance = await harness.navigateByUrl('test', TestComponent);

Expand Down Expand Up @@ -127,6 +135,7 @@ export class TestComponent implements OnInit {
fragmentDefaultValue = injectRouteFragment({
defaultValue: 'default-fragment',
});
zeroFragmentDefaultValue = injectRouteFragment({ defaultValue: 0 });
Comment thread
eneajaho marked this conversation as resolved.
isFragmentAvailable = injectRouteFragment({
parse: (fragment) => !!fragment,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function injectRouteFragment<T>(
const route = inject(ActivatedRoute);
const initialRouteFragment = route.snapshot.fragment;
const getFragment = (fragment: string | null) => {
if (fragment === null && options?.defaultValue) {
if (fragment === null && options?.defaultValue !== undefined) {
return options.defaultValue;
}
if (options?.parse) {
Expand Down
Loading