feat(effects): add FEATURE_EFFECTS_INIT lifecycle action#5131
Open
feat(effects): add FEATURE_EFFECTS_INIT lifecycle action#5131
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Much needed feature. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, when app needs to wait for feature effects readiness, it can only use
OnInitEffects.If the app has a lot of feature effects and needs to wait for a group of them to be ready, it would require to add
OnInitEffectson each effect in the group. And then to listen to all of the actions dispatched by eachOnInitEffects.This would be a lot of boilerplate and this kind of init logic would be pretty fragile.
What is the new behavior?
FEATURE_EFFECTS_INIT action is dispatched after all feature effects are added.
In similar fashion to existing ROOT_EFFECTS_INIT.
Does this PR introduce a breaking change?
Other information