Skip to content

Bump versions for nginx, njs, and alpine#1058

Merged
thresheek merged 5 commits into
nginx:masterfrom
thresheek:updates-jul15
Jul 15, 2026
Merged

Bump versions for nginx, njs, and alpine#1058
thresheek merged 5 commits into
nginx:masterfrom
thresheek:updates-jul15

Conversation

@thresheek

Copy link
Copy Markdown
Member

Proposed changes

This PR:

@thresheek
thresheek requested a review from a team as a code owner July 15, 2026 19:09
@thresheek

Copy link
Copy Markdown
Member Author

Looking on why it's all red...

@mschfh

mschfh commented Jul 15, 2026

Copy link
Copy Markdown

@thresheek Any thoughts about adding module (smoke) tests to pkg-oss?

@thresheek

Copy link
Copy Markdown
Member Author

hey @mschfh,

Indeed, pkg-oss tests whether the subset of first-party and third-party modules do build with the current change, but we don't specifically test whether they actually work. I'm not even sure it's a good idea to do that for third-party modules (and block the PR acceptance) since it's OK for NGINX to introduce breaking changes, and module authors are supposed to follow up.

@thresheek
thresheek merged commit e0f008f into nginx:master Jul 15, 2026
10 checks passed
@thresheek
thresheek deleted the updates-jul15 branch July 15, 2026 21:05
This was referenced Jul 15, 2026
@mschfh

mschfh commented Jul 15, 2026

Copy link
Copy Markdown

@thresheek Makes sense, what about non-blocking tests?
From my understanding, the current (contrib) code in the pkg-oss repo is broken without any indication of it.
Additional tests would also help to prevent regressions (or validate fixes) when updating the module version itself.

@thresheek

Copy link
Copy Markdown
Member Author

@mschfh I fully agree. Let's move the discussion over to nginx/pkg-oss#125 - much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants