You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Indeed, pkg-oss tests whether the subset of first-party and third-party modules do build with the current change, but we don't specifically test whether they actually work. I'm not even sure it's a good idea to do that for third-party modules (and block the PR acceptance) since it's OK for NGINX to introduce breaking changes, and module authors are supposed to follow up.
@thresheek Makes sense, what about non-blocking tests?
From my understanding, the current (contrib) code in the pkg-oss repo is broken without any indication of it.
Additional tests would also help to prevent regressions (or validate fixes) when updating the module version itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR: