fix: support range with a single variable#32
Open
guilhas07 wants to merge 2 commits intongalaiko:masterfrom
Open
fix: support range with a single variable#32guilhas07 wants to merge 2 commits intongalaiko:masterfrom
guilhas07 wants to merge 2 commits intongalaiko:masterfrom
Conversation
Problem: Rules like `variable_definition`, `assignment`, `range_action`, `template_action`, `chained_pipeline`, `argument_list` incorrectly allowed for variable definitions and assignments inside them. Solution: Remove rules `variable_definition` and `assignment` from `pipeline`, using a new rule where both are supported.
Problem:
`range_action` currently doesn't support statements like:
{{ range $value := $elements }}
expecting always a `index` variable, before the `$value`.
Solution:
Make the index optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
range_actioncurrently doesn't support statements like:expecting always a
indexvariable, before the$value.Solution:
Make the index optional.
Depends on #31