Flipped knownKey - #1
Merged
Merged
Conversation
MFOC patches have now been ported upstream
MFOC patches have been ported upstream
Contributor
|
I can confirm that by using @indocomsoft 's fork I retrieved some keys with success, while I was getting errors with current revision. |
|
I think this should have been fixed by my PR in mfoc ( nfc-tools/mfoc#44 ) instead of this dirty hack here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
miLazyCracker.shcallslibnfc_crypto1_crack, it passes a flipped around$knownKey, e.g. if the key isb0b1b2b3b4b5, it was parsed asb5b4b3b2b1b0.My PR fixed that.