chore(deps): update dependency psalm/phar to v7 (master)

lib/AppInfo/Application.php

@@ -23,8 +23,9 @@
 class Application extends App implements IBootstrap {
 	public const APP_ID = 'suspicious_login';
 
+	/** @psalm-mutation-free */
 	public function __construct(array $urlParams = []) {
 		parent::__construct(self::APP_ID, $urlParams);
 	}
 
 	#[\Override]
@@ -39,6 +40,6 @@
 	}
 
 	#[\Override]
 	public function boot(IBootContext $context): void {
 	}
 }

lib/Command/ETL.php

@@ -15,6 +15,7 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
+/** @psalm-immutable */
 class ETL extends Command {
 
 	public function __construct(

lib/Command/Optimize.php

@@ -19,6 +19,7 @@
 use function extension_loaded;
 use function time;
 
+/** @psalm-immutable */
 class Optimize extends Command {
 	use ModelStatistics;
 

lib/Command/Predict.php

@@ -20,6 +20,7 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
+/** @psalm-immutable */
 class Predict extends Command {
 
 	public function __construct(

lib/Command/Seed.php

@@ -18,6 +18,7 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
+/** @psalm-immutable */
 class Seed extends Command {
 	use ModelStatistics;
 

lib/Command/Train.php

@@ -24,6 +24,7 @@
 use function extension_loaded;
 use function time;
 
+/** @psalm-immutable */
 class Train extends Command {
 	use ModelStatistics;
 

lib/Db/LoginAddressAggregatedSeeder.php

@@ -17,6 +17,7 @@ class LoginAddressAggregatedSeeder {
 	/** @var IDBConnection */
 	private $db;
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		IDBConnection $db,
 		private readonly LoginAddressAggregatedMapper $mapper,

lib/Db/Model.php

@@ -65,6 +65,7 @@ class Model extends Entity implements JsonSerializable {
 	protected $createdAt;
 	protected $addressType;
 
+	/** @psalm-mutation-free */
 	#[\Override]
 	#[ReturnTypeWillChange]
 	public function jsonSerialize(): array {

lib/Exception/InsufficientDataException.php

@@ -10,6 +10,7 @@
 namespace OCA\SuspiciousLogin\Exception;
 
 class InsufficientDataException extends ServiceException {
+	/** @psalm-mutation-free */
 	public function __construct(string $message = '') {
 		parent::__construct(
 			$message === '' ? 'Insufficient data' : "Insufficient data: $message"

lib/Listener/LoginListener.php

@@ -21,6 +21,7 @@
  * @implements IEventListener<UserLoggedInEvent>
  */
 class LoginListener implements IEventListener {
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly IRequest $request,
 		private readonly ITimeFactory $timeFactory,

lib/Listener/LoginMailListener.php

@@ -25,6 +25,7 @@
  */
 class LoginMailListener implements IEventListener {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly LoggerInterface $logger,
 		private readonly IMailer $mailer,

lib/Listener/LoginNotificationListener.php

@@ -21,6 +21,7 @@
  */
 class LoginNotificationListener implements IEventListener {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly IManager $notificationManager,
 		private readonly ITimeFactory $timeFactory,

lib/Migration/Version4002Date20220922094803.php

@@ -22,6 +22,7 @@ class Version4002Date20220922094803 extends SimpleMigrationStep {
 	 */
 	protected $connection;
 
+	/** @psalm-mutation-free */
 	public function __construct(IDBConnection $connection) {
 		$this->connection = $connection;
 	}

lib/Migration/Version9000Date20250114095826.php

@@ -18,6 +18,7 @@
 
 class Version9000Date20250114095826 extends SimpleMigrationStep {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly IJobList $jobList,
 	) {

lib/Notifications/Notifier.php

@@ -33,13 +33,15 @@ class Notifier implements INotifier {
 	/** @var IURLGenerator */
 	protected $url;
 
+	/** @psalm-mutation-free */
 	public function __construct(IFactory $factory, IRequest $request, IConfig $config, IURLGenerator $urlGenerator) {
 		$this->config = $config;
 		$this->factory = $factory;
 		$this->request = $request;
 		$this->url = $urlGenerator;
 	}
 
+	/** @psalm-pure */
 	#[\Override]
 	public function getID(): string {
 		return Application::APP_ID;

lib/Service/AClassificationStrategy.php

@@ -20,11 +20,14 @@
 use function str_split;
 
 abstract class AClassificationStrategy {
+	/** @psalm-pure */
 	abstract public static function getTypeName(): string;
 
+	/** @psalm-impure */
 	abstract public function hasSufficientData(LoginAddressAggregatedMapper $loginAddressMapper, int $validationDays): bool;
 
 	/**
+	 * @psalm-impure
 	 * @return LoginAddressAggregated[][]
 	 */
 	abstract public function findHistoricAndRecent(LoginAddressAggregatedMapper $loginAddressMapper, int $validationThreshold, int $maxAge): array;
@@ -47,6 +50,7 @@
 	}
 
 	/**
+	 * @psalm-pure
 	 * @param string $ip
 	 *
 	 * @return int[]
@@ -74,21 +78,25 @@
 	 * @psalm-param 10|16 $base
 	 * @psalm-param 4|8 $padding
 	 */
 	protected function numStringsToBitArray(array $strings, int $base, int $padding): array {
 		$converted = array_reduce(array_map(fn (string $s) => $this->numStringToBitArray($s, $base, $padding), $strings), array_merge(...), []);
 		return array_map(fn ($x) => (int)$x, $converted);
 	}
 
+	/** @psalm-pure */
 	protected function numStringToBitArray(string $s, int $base, int $padding): array {
 		$bin = base_convert($s, $base, 2);
 		// make sure we get 00000000 to 11111111
 		$padded = str_pad($bin, $padding, '0', STR_PAD_LEFT);
 		return str_split($padded);
 	}
 
+	/** @psalm-impure */
 	abstract public function generateRandomIp(): string;
 
+	/** @psalm-pure */
 	abstract public function getSize(): int;
 
+	/** @psalm-mutation-free */
 	abstract public function getDefaultMlpConfig(): Config;
 }

lib/Service/CollectedData.php

@@ -11,7 +11,9 @@
 
 use Rubix\ML\Datasets\Labeled;
 
+/** @psalm-immutable */
 class CollectedData {
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly Labeled $trainingPositives,
 		private readonly Labeled $validationPositives,

lib/Service/DataLoader.php

@@ -28,6 +28,7 @@ class DataLoader {
 	private const MAX_SAMPLES_POSITIVES = 15_000;
 	private const MAX_SAMPLES_VALIDATE_POSITIVES = 3_000;
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly LoginAddressAggregatedMapper $loginAddressMapper,
 		private readonly NegativeSampleGenerator $negativeSampleGenerator,

lib/Service/ETLService.php

@@ -20,6 +20,7 @@
 class ETLService {
 	public const MAX_BATCH_SIZE = 10000;
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly IDBConnection $db,
 		private readonly LoginAddressAggregatedMapper $aggregatedMapper,

lib/Service/EstimatorService.php

@@ -17,6 +17,7 @@
 
 class EstimatorService {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly ModelStore $modelStore,
 		private readonly LoggerInterface $logger,

lib/Service/IpV6Strategy.php

@@ -22,6 +22,7 @@
 use function substr;
 
 class IpV6Strategy extends AClassificationStrategy {
+	/** @psalm-pure */
 	#[\Override]
 	public static function getTypeName(): string {
 		return 'ipv6';
@@ -37,9 +38,10 @@
 		return $loginAddressMapper->findHistoricAndRecentIpv6($validationThreshold, $maxAge);
 	}
 
+	/** @psalm-pure */
 	#[\Override]
 	protected function ipToVec(string $ip): array {
 		$strippedIp = IPv6AddressParser::stripScopeIdentifier($ip);
 		$addr = inet_pton($strippedIp);
 		if ($addr === false) {
 			throw new InvalidArgumentException('Invalid IPv6 address');
@@ -61,13 +63,15 @@
 		return implode(':', array_map(fn (int $index) => base_convert((string)random_int(0, 2 ** 16 - 1), 10, 16), range(0, 7)));
 	}
 
+	/** @psalm-pure */
 	#[\Override]
 	public function getSize(): int {
 		return 16 + 64;
 	}
 
+	/** @psalm-mutation-free */
 	#[\Override]
 	public function getDefaultMlpConfig(): Config {
 		return Config::default()->setEpochs(20);
 	}
 }

lib/Service/Ipv4Strategy.php

@@ -15,6 +15,7 @@
 use function explode;
 
 class Ipv4Strategy extends AClassificationStrategy {
+	/** @psalm-pure */
 	#[\Override]
 	public static function getTypeName(): string {
 		return 'ipv4';
@@ -47,13 +48,15 @@
 		return implode('.', array_map(fn (int $index) => random_int(0, 255), range(0, 3)));
 	}
 
+	/** @psalm-pure */
 	#[\Override]
 	public function getSize(): int {
 		return 16 + 32;
 	}
 
+	/** @psalm-mutation-free */
 	#[\Override]
 	public function getDefaultMlpConfig(): Config {
 		return Config::default();
 	}
 }

lib/Service/LoginClassifier.php

@@ -28,6 +28,7 @@
 
 class LoginClassifier {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly EstimatorService $estimator,
 		private readonly IRequest $request,

lib/Service/LoginDataCollector.php

@@ -14,6 +14,7 @@
 
 class LoginDataCollector {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly LoginAddressMapper $addressMapper,
 	) {

lib/Service/MLP/Config.php

@@ -23,6 +23,7 @@ public function __construct(
 	) {
 	}
 
+	/** @psalm-pure */
 	public static function default() {
 		return new static(
 			330,

lib/Service/MLP/OptimizerService.php

@@ -38,12 +38,14 @@ class OptimizerService {
 		'learningRate' => [0.0001, 0.01],
 	];
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly DataLoader $loader,
 		private readonly Trainer $trainer,
 	) {
 	}
 
+	/** @psalm-mutation-free */
 	private function printConfig(int $epoch,
 		float $stepWidth,
 		Config $config,

lib/Service/MLP/Trainer.php

@@ -33,6 +33,7 @@ class Trainer {
 	/** @var ITimeFactory */
 	private $timeFactory;
 
+	/** @psalm-mutation-free */
 	public function __construct(ITimeFactory $timeFactory) {
 		$this->timeFactory = $timeFactory;
 	}

lib/Service/ModelStore.php

@@ -34,6 +34,7 @@
 class ModelStore {
 	public const APPDATA_MODELS_FOLDER = 'models';
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly ModelMapper $modelMapper,
 		private readonly IAppData $appData,
@@ -59,6 +60,7 @@ public function loadLatest(AClassificationStrategy $strategy): Estimator {
 		return $this->load($latestModel->getId());
 	}
 
+	/** @psalm-pure */
 	private function getCacheKey(int $id): string {
 		return "suspicious_login_model_$id";
 	}

lib/Service/NotificationState.php

@@ -7,6 +7,7 @@
  */
 namespace OCA\SuspiciousLogin\Service;
 
+/** @psalm-immutable */
 class NotificationState {
 	public const SENT = 1;
 	public const NOT_SENT_DUPLICATE = 2;

lib/Service/Statistics/AppStatistics.php

@@ -21,6 +21,7 @@
 
 class AppStatistics implements JsonSerializable {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly bool $active,
 		/** @var Model[] */
@@ -58,6 +59,7 @@ public function getTrainingDataStatistics(): TrainingDataStatistics {
 		return $this->trainingDataStatistics;
 	}
 
+	/** @psalm-mutation-free */
 	#[\Override]
 	#[ReturnTypeWillChange]
 	public function jsonSerialize(): array {

lib/Service/Statistics/TrainingDataStatistics.php

@@ -14,6 +14,7 @@
 
 class TrainingDataStatistics implements JsonSerializable {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly int $loginsCaptured,
 		private readonly int $loginsAggregated,
@@ -34,6 +35,7 @@ public function getLoginsAggregated(): int {
 		return $this->loginsAggregated;
 	}
 
+	/** @psalm-mutation-free */
 	#[\Override]
 	#[ReturnTypeWillChange]
 	public function jsonSerialize(): array {

lib/Service/StatisticsService.php

@@ -18,6 +18,7 @@
 
 class StatisticsService {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly LoginAddressMapper $loginAddressMapper,
 		private readonly LoginAddressAggregatedMapper $loginAddressAggregatedMapper,

lib/Service/TrainService.php

@@ -17,6 +17,7 @@
 
 class TrainService {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private readonly DataLoader $dataLoader,
 		private readonly Trainer $trainer,

lib/Service/TrainingDataConfig.php

@@ -15,6 +15,7 @@
 
 class TrainingDataConfig implements JsonSerializable {
 
+	/** @psalm-mutation-free */
 	public function __construct(
 		private int $maxAge,
 		private int $threshold,
@@ -80,6 +81,7 @@ public function setNow(int $now): TrainingDataConfig {
 		return $clone;
 	}
 
+	/** @psalm-mutation-free */
 	#[\Override]
 	#[ReturnTypeWillChange]
 	public function jsonSerialize(): array {