Skip to content

fix: Update manifest link generation to use IURLGenerator #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prplecake wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix: Update manifest link generation to use IURLGenerator #2424

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
770205b
fix: Update manifest link generation to use IURLGenerator
prplecake May 9, 2026
d729d6c
Apply suggestion from @marcelklehr
marcelklehr May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/AugmentedTemplateResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

use OC;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\IURLGenerator;

/**
* @template S of \OCP\AppFramework\Http::STATUS_*
Expand All @@ -19,7 +20,7 @@
class AugmentedTemplateResponse extends TemplateResponse {
public function render() {
$return = parent::render();
preg_replace('/<link rel="manifest" href="(.*?)">/i', '<link rel="manifest" href="' . OC::$server->getURLGenerator()->linkToRouteAbsolute('bookmarks.web_view.manifest') . '">', $return);
preg_replace('/<link rel="manifest" href="(.*?)">/i', '<link rel="manifest" href="' . OC::$server->get(IURLGenerator::class)->linkToRouteAbsolute('bookmarks.web_view.manifest') . '">', $return);
Comment thread
marcelklehr marked this conversation as resolved.
Outdated
return $return;
}
}