Backport of sabre-io/vobject#716 -- support RDATE together with RRULE. - #2088
Open
rotdrop wants to merge 2 commits into
Open
Backport of sabre-io/vobject#716 -- support RDATE together with RRULE.#2088rotdrop wants to merge 2 commits into
rotdrop wants to merge 2 commits into
Conversation
rotdrop
force-pushed
the
bugfix/sabre-supprot-rrules-with-rdates
branch
from
June 20, 2025 18:57
05fd96b to
f00eac9
Compare
Author
|
Oops. This should be modelled in the context of cweagans/composer-patches. Ok. I'll eventually do this. |
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
rotdrop
force-pushed
the
bugfix/sabre-supprot-rrules-with-rdates
branch
from
June 21, 2025 10:36
f00eac9 to
e6493f1
Compare
Author
Refactored using composer-patches framework. |
ChristophWurst
requested review from
SebastianKrupinski and
st3iny
and removed request for
ChristophWurst
July 15, 2025 08:33
Contributor
|
Hi @rotdrop We are not apposed to these changes but will need to review and test them first. Please give us a bit of time to do so. |
Contributor
|
I commented on your PR in the SabreDAV repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer also or even primarily to the discussions of the respective issues and PRs of the upstream Sabre project:
This is a backport of the (not yet accepted) PR sabre-io/vobject#716
The base of the PR is that in my user community we have a wild mixture of users (Windoze, half-eaten-apple, me as Linux guy), and this case of mixed RRULE and RDATE just occurs, example:
This is fully supported by the CalDAV standard which states that the total recurrence-set is just the union of the events defined by RRULE as well as RDATE directives.