Refactor manage.sh: split activation and installation actions - #969
Open
gonzaponte wants to merge 2 commits into
Open
Refactor manage.sh: split activation and installation actions#969gonzaponte wants to merge 2 commits into
manage.sh: split activation and installation actions#969gonzaponte wants to merge 2 commits into
Conversation
`activate` (formerly known as `work_in_python_version`) used to mean "do whatever you need to do to set up IC now". This has lead to multiple cases of confusion because it installs conda if the user forgets to activate it, and other more intricate issues. This commit wants to split functionalities and make them more clear, at the expense of forcing the user to know what they want to do. Moreover, the new procedure to compile cython stuff is painfully slow, so it will only be done by default in the installation step.
gonzaponte
force-pushed
the
activate-fast
branch
from
July 29, 2026 10:09
90280a3 to
1187fc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
activateresponsible only for activating an existing environment.Remove implicit
condaand environment installation and cython compilation from activation, since those operations are already handled by dedicated commands. Moreover, the new procedure to compile cython stuff is painfully slow, so it will only be done by default in the installation step.This avoids unnecessary work during activation and makes command behavior more explicit and predictable at the expense of forcing the user to learn more than one instruction.
A new installation now requires
bash manage.sh install_and_checkwhile, once installed, one just needs to do
source manage.sh activate.The activation step still checks for the availability of conda and the environment to guide the user.