Repository navigation
fix: move pandas to the dev group so CI installs it - #44
Merged
Merged
Conversation
test_dictionary_geog_id_deduplicates_repeated_ids calls to_pandas() to prove a dictionary with repeated categories does not blow up. pandas sat in the troubleshooting group, but CI installs with poetry export --with dev --extras arrow so pandas was never present there and the test failed with ModuleNotFoundError. It passed locally only because a dev machine with the troubleshooting group installed happens to have it. That one failure skipped every job downstream of `tests` — linux, musllinux, macos, windows, sdist and release all need it — so the v0.7.0 tag built and published nothing. PyPI is still on 0.6.4. Moving pandas to dev rather than guarding the test with importorskip: the assertion is about a real pandas interaction, so it should run in CI rather than silently skip there. Lock change is group reassignment only; no version moved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_dictionary_geog_id_deduplicates_repeated_idscallsto_pandas()to prove a dictionary with repeated categories does not blow up. pandas sat in thetroubleshootinggroup, but CI installs withso pandas was never present there and the test failed with
ModuleNotFoundError. It passed locally only because a dev machine with the troubleshooting group installed happens to have it.That one failure skipped every job downstream of
tests—linux,musllinux,macos,windows,sdistandreleaseall need it. So thev0.7.0tag built and published nothing: the GitHub release has 0 assets and PyPI is still on 0.6.4.Moving pandas to
devrather than guarding the test withimportorskip: the assertion is about a real pandas interaction, so it should run in CI rather than silently skip there.Lock change is group reassignment only; no version moved.
Verified locally: 190 tests pass,
mypy --strictclean, andpoetry export --with dev --extras arrownow containspandas==2.3.3.🤖 Generated with Claude Code