fix: typo with no-fetch help message#649
Conversation
ariyonaty
force-pushed
the
patch/typo-in-help
branch
from
d756fb3 to
27955ab
Compare
There was a problem hiding this comment.
Like git.git, for commit messages we want it of the form "area: summary" not "change-type: summary". Could you adjust to "filter-repo: fix typo with no-fetch help message"?
Also, for the Signed-off-by, we need it to be of the form Real Name <real@email.address>; not username <username@fake.address>; @users.noreply.github.com addresses don't suffice. Can you fix this as well?
I'll be happy to apply with these two changes.
ariyonaty
force-pushed
the
patch/typo-in-help
branch
from
27955ab to
09fc795
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
newren
left a comment
newren
left a comment
There was a problem hiding this comment.
Sorry, I missed this the first time, but the Author and Committer on the patch need the same fix that the signed-off-by needed. Can you fix that up?
Signed-off-by: Ari Yonaty <ari.h.yonaty@gmail.com>
ariyonaty
force-pushed
the
patch/typo-in-help
branch
from
09fc795 to
a4887fa
Compare
|
Sorry for the delay. Looks like you fixed up the Author, but not the Committer. Can you fix that up? ( |
3 participants
No description provided.