Repository navigation
tests: unbreak the --package e2e variant (.pkg-stage was dockerignored) - #51
Merged
Merged
Conversation
b52274e added tests/e2e/.pkg-stage/ to .dockerignore one day after the --package variant was introduced — but Containerfile.pkg COPYs the staged .deb/.rpm from exactly that directory, so every packaged e2e since failed at the image build with 'no items matching glob'. Undetected until the new per-push gate ran e2e-package for the first time since the v1.2.0 cut and caught it on all four distros. Drop the exclusion (the dir is transient and .gitignored) and add .dockerignore to the release.yml paths filter — it shapes what the packaged e2e can build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b52274e added tests/e2e/.pkg-stage/ to .dockerignore one day after the --package variant was introduced — but Containerfile.pkg COPYs the staged .deb/.rpm from exactly that directory, so every packaged e2e since failed at the image build with 'no items matching glob'. Undetected until the new per-push gate ran e2e-package for the first time since the v1.2.0 cut and caught it on all four distros.
Drop the exclusion (the dir is transient and .gitignored) and add .dockerignore to the release.yml paths filter — it shapes what the packaged e2e can build.