Skip to content

refactor: remove more dead "addons" code - #8594

Merged
serhalp merged 1 commit into
mainfrom
serhalp/refactor/remove-more-addons-stuff
Oct 8, 2026
Merged

serhalp merged 1 commit into
mainfrom
serhalp/refactor/remove-more-addons-stuff

Conversation

@serhalp

@serhalp serhalp commented Oct 7, 2026

Copy link
Copy Markdown
Member

Summary

This is very old, unused code for something that no longer exists. Delete it.

@serhalp
serhalp added this pull request to stack #8595 October 7, 2026 20:06
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: ce631e6c-044c-44dc-886a-d151ef1c8bdc
📥 Commits

Reviewing files that changed from the base of the PR and between 31c4723 and 6c6de6c.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: c8fea85f-486a-4083-9a45-b42b11584603
📥 Commits

Reviewing files that changed from the base of the PR and between bc007d2 and afdf219.

📒 Files selected for processing (13)
  • CLAUDE.md
  • eslint-suppressions.json
  • src/commands/dev/dev.ts
  • src/commands/functions/functions-create.ts
  • src/commands/serve/serve.ts
  • src/lib/edge-functions/registry.ts
  • src/utils/addons/prepare.ts
  • src/utils/dev.ts
  • src/utils/env/index.ts
  • src/utils/parse-raw-flags.ts
  • src/utils/proxy-server.ts
  • src/utils/proxy.ts
  • src/utils/types.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

💤 Files with no reviewable changes (5)
  • src/lib/edge-functions/registry.ts
  • src/utils/addons/prepare.ts
  • src/utils/env/index.ts
  • src/utils/proxy.ts
  • src/utils/proxy-server.ts

Included review availability: This review used your included allowance. 9 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC.


📝 Summary

Summary by CodeRabbit

  • Behavior Changes
    • Add-on-provided environment variables are no longer included in local development or edge-function configuration. Existing environment-variable sources and their precedence remain unchanged.
    • Local development and serving no longer route requests through add-on-specific proxy URLs.
    • Creating functions from templates or GitHub URLs no longer installs template add-ons or prompts for add-on setup.

Walkthrough

Environment-variable handling no longer includes addon-provided variables. Local development and serve flows no longer retrieve addon URLs or pass them to the proxy. Function-template scaffolding no longer installs template addons or runs addon-specific setup. The addon preparation helpers were deleted.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to afdf2

This change removes unused addon code paths. No concrete regression is evident in the supplied changes, so it is low risk to merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing obsolete addons code.
Description check ✅ Passed The description states that the code is old, unused, and should be deleted, which directly relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@serhalp
serhalp force-pushed the serhalp/refactor/remove-more-addons-stuff branch from 777f49e to afdf219 Compare October 7, 2026 20:06
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

📊 Benchmark results

Comparing with 0f2b082

  • Dependency count: 1,019 (no change)
  • Package size: 380 MB (no change)
  • Number of ts-expect-error directives: 319 ⬇️ 3.76% decrease vs. 0f2b082

@pkg-pr-new

pkg-pr-new Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/netlify-cli@8594

commit: 6c6de6c

@serhalp
serhalp marked this pull request as ready for review October 7, 2026 20:37
@serhalp
serhalp requested a review from a team as a code owner October 7, 2026 20:37
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

sarahetter
sarahetter previously approved these changes Oct 7, 2026
Base automatically changed from serhalp/chore/eslint-bulk-suppressions to main October 8, 2026 14:38
@serhalp
serhalp dismissed sarahetter’s stale review October 8, 2026 14:38

The merge-base changed after approval.

@serhalp
serhalp force-pushed the serhalp/refactor/remove-more-addons-stuff branch from afdf219 to 31c4723 Compare October 8, 2026 14:38
@serhalp
serhalp requested a review from sarahetter October 8, 2026 14:39
This is very old, unused code for something that no longer exists.
@serhalp
serhalp force-pushed the serhalp/refactor/remove-more-addons-stuff branch from 31c4723 to 6c6de6c Compare October 8, 2026 16:27
@serhalp
serhalp merged commit ab30265 into main Oct 8, 2026
37 checks passed
@serhalp
serhalp deleted the serhalp/refactor/remove-more-addons-stuff branch October 8, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants