Repository navigation
chore(main): release 27.12.0 - #8575
Merged
sarahetter merged 1 commit intoOct 8, 2026
Merged
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
commit: |
token-generator-app
Bot
force-pushed
the
release-please--branches--main--components--netlify-cli
branch
3 times, most recently
from
October 7, 2026 16:14
4f6779d to
af3be42
Compare
token-generator-app
Bot
force-pushed
the
release-please--branches--main--components--netlify-cli
branch
2 times, most recently
from
October 8, 2026 16:23
bd5b1fe to
728b9f8
Compare
domitriusclark
added a commit
that referenced
this pull request
Oct 8, 2026
## Problem `netlify dev` returns 403 on Windows for static files that need a redirect shadow check, such as paths with spaces or brackets. `getStatic` builds the URL forwarded to the static server with `path.relative`, which yields backslashes on Windows, so the static server receives `/files%5Cfile%20with%20spaces.html`. This has been latent since 2020. `@fastify/static` 10.1.4 (GHSA-r799-r9gc-m956) added a path spelling guard that splits on `/`, stats the joined path, finds the file under a different spelling, and rejects it. Earlier versions served the file. Surfaced by the Windows integration shard on #8575, which fails `should not shadow an existing file that has unsafe URL characters` on every attempt. The previous five release PRs passed it. ## Approach Split the relative path on `path.sep` and join with `/`, so the URL always uses forward slashes. Only OS separators are rewritten; a literal backslash in a POSIX filename is preserved. ## Tests - `npm run typecheck`, `npx eslint src/utils/proxy.ts`, `npm run build`: clean - `npm exec vitest -- run tests/integration/commands/dev/dev.test.ts` with `@fastify/static` 10.1.5 installed: 27 passed Verified on macOS only, where `path.relative` already returns forward slashes, so this run cannot reproduce the bug. PRs do not run Windows integration tests. The proof is the Windows shard on the regenerated release PR after this merges. ## Risk Low. One-line change on the path the proxy already controls. No behavior change on POSIX, where `path.sep` is already `/`. ## Rollback Revert this commit.
token-generator-app
Bot
force-pushed
the
release-please--branches--main--components--netlify-cli
branch
from
October 8, 2026 17:21
728b9f8 to
b75c3a3
Compare
sarahetter
approved these changes
Oct 8, 2026
sarahetter
enabled auto-merge (squash)
October 8, 2026 18:23
sarahetter
deleted the
release-please--branches--main--components--netlify-cli
branch
October 8, 2026 18:34
Contributor
Author
|
🤖 Created releases: 🌻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
27.12.0 (2026-10-08)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.