WIP: Feature django-cms 4.0.x compatibility#672
Open
Aiky30 wants to merge 6 commits intonephila:developfrom
Open
WIP: Feature django-cms 4.0.x compatibility#672Aiky30 wants to merge 6 commits intonephila:developfrom
Aiky30 wants to merge 6 commits intonephila:developfrom
Conversation
…n't yet occured but the code is trying to run in Docker
Aiky30
commented
Sep 24, 2022
| "BlogConfig.namespace {} and BlogConfig.app_title {} are" | ||
| "unique together".format(seed, config.namespace, config.app_title) | ||
| ) | ||
| try: |
Author
There was a problem hiding this comment.
This needs moving to the cms_config to work using the new app registration system which replaces pools: https://github.com/django-cms/django-cms/blob/28d3fa54cb8795fc2276ada94e07f45fa2fe1def/cms/cms_config.py#L18
36e5e25 to
5220d47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe:
References
Provide any github issue fixed (as in
Fix #XYZ)Checklist
inv lintchangesfile included (see docs)