Fix lastWrittenLsnCache eviction order#12906
Open
mingjiegao wants to merge 1 commit into
Open
Conversation
a1d9985 to
5032cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
lastWrittenLsnCacheis expected to stay withinneon.last_written_lsn_cache_size. However, when the cache is full, inserting before eviction can require one extra shared hash entry.With a fixed-size shared hash table, this can fail with
out-of-shared-memory.Summary
Fixes #12905.
This PR changes
lastWrittenLsnCacheso that when a new entry needs to be inserted and the cache is already full, an existing entry is evicted before inserting the new one.Previously, the code inserted the new entry first and evicted afterwards. This could temporarily require
neon.last_written_lsn_cache_size + 1hash entries.Fix
For new keys, the code now ensures capacity before calling
HASH_ENTER:Testing
neon.last_written_lsn_cache_size = 10and addingHASH_FIXED_SIZEto theShmemInitHashcall forlastWrittenLsnCache.out-of-shared-memory.I did not add an automated test because the failure depends on shared hash table sizing and concurrent workload behavior. I would appreciate guidance on the best test location for this case.