fix(pageserver): prevent stack overflow in count_deltas#12904
Open
AesaKamar wants to merge 1 commit into
Open
Conversation
c3a1d22 to
0c2c57e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a stack overflow in the pageserver's
LayerMap::count_deltasfunction (resolving #3711).test_count_deltas_stack_overflowinlayer_map.rswhich verifies that evaluating a stack of 10,000 delta layers completes successfully without crashing.P.S. This is another contribution following up on my first PR! The iterative version runs safely and extremely fast (the regression test passes in <0.3s). I would love any feedback on the implementation!