Fix require#149
Open
Whoome wants to merge 5 commits into
Open
Conversation
… C native librares are supported and package.config is still ignored.
Owner
|
Are you so kind and split the pull requests?
public class LuaMath : LuaTable
{
[LuaMember]
public double abs(double value)
...it is functional equal to math["abs"] = new Func<double, double>(Abs);but supports overloads and is a little bit optimized. Only variables should be set like math["PI"] = Math.PIOr public double PI => Math.PI;The last variant, can be reset by If do not want, the value should be changed: [LuaMember]
public double PI {get => Math.PI; set {} }And please fix the formatting of your changes. Overall good work. |
Owner
|
Can you rebase this pull request? |
Owner
|
It would be nice, if you rebase or send me a diff with your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed require to work the same as Lua 5.3, with the exception that no C native librares are supported and package.config is still ignored.