Skip to content

update for node24#145

Merged
neilenns merged 2 commits into
neilenns:mainfrom
SocksTheWolf:main
Mar 27, 2026
Merged

update for node24#145
neilenns merged 2 commits into
neilenns:mainfrom
SocksTheWolf:main

Conversation

@SocksTheWolf
Copy link
Copy Markdown
Contributor

@SocksTheWolf SocksTheWolf commented Mar 19, 2026

plugin works in my workflows but can't run the full pipeline on my linux runner locally because jest gets angry (gh core/actions requires you to have all env variables setup before run, but windows you can inject), but works totally fine on windows, yahoo.

This should probably be moved to ESM at some point in the future, as the versions I've pinned to, are the last to support CJS.

Summary by CodeRabbit

  • Chores

    • Upgraded minimum Node.js requirement to v24 and updated core runtime targets.
    • Updated dependencies and development tooling to newer major/minor versions.
  • Bug Fixes

    • Fixed version-string generation to tolerate missing environment values.
    • Corrected a typo in an input description.
  • Tests

    • Removed a deprecated test suite.

jest works if you set env variables, but can't test because on linux
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

Node.js runtime bumped from 20 → 24 across configs and metadata; dependencies upgraded; a Jest test file was removed; action.yml typo fixed; getVersion() fallback in src/main.js now substitutes 0 when GITHUB_RUN_NUMBER is unset.

Changes

Cohort / File(s) Summary
Node.js & metadata
/.node-version, package.json, action.yml
Node runtime raised from 20 to 24; engines.node>=24; multiple dependency and devDependency version upgrades.
Action config
action.yml
runs.using changed from node20node24; typo corrected in inputs.force.description ("overwites" → "overwrites").
Tests
__tests__/wait.test.js
Removed test suite for src/wait.js (two async tests: invalid-arg rejection and timing assertion).
Source
src/main.js
getVersion() fallback now uses `...${process.env.GITHUB_RUN_NUMBER

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through files with speedy paws,

bumped versions, fixed a clause.
Tests hopped out, a typo mended,
Fallbacks snug — the build transcended.
✨🐇

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'update for node24' accurately describes the main change across the changeset: updating Node.js version from 20 to 24 in multiple files (.node-version, action.yml, package.json engines).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
package.json (1)

80-80: Note: Jest 30 and Linux compatibility.

The PR description mentions Jest fails on Linux, blocking local test execution. This may be related to the Jest 30 upgrade or CommonJS/ESM module resolution in Node 24. The contributor notes environment variables need to be set for Jest to work.

Consider documenting the required environment configuration or investigating the root cause before merging if CI testing is critical.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 80, The Jest upgrade ("jest": "^30.3.0") appears to
cause Linux/local test failures (likely Node24 CJS/ESM or env var expectations);
either revert/pin the "jest" dependency to the last-known-good version, or
reproduce the failure locally and fix module/resolution/config (jest.config or
transform settings) and update CI; additionally add a short note in
README/CONTRIBUTING about required environment variables and Node/Jest
compatibility so contributors can run tests locally. Locate the "jest" entry in
package.json and update dependency or add documentation and CI fixes
accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.node-version:
- Line 1: Replace the partial Node version string "24.11" in .node-version with
the full semver form "24.11.0" to explicitly pin the Node runtime; update the
file contents so any version manager or CI tooling reads the complete semantic
version.

---

Nitpick comments:
In `@package.json`:
- Line 80: The Jest upgrade ("jest": "^30.3.0") appears to cause Linux/local
test failures (likely Node24 CJS/ESM or env var expectations); either revert/pin
the "jest" dependency to the last-known-good version, or reproduce the failure
locally and fix module/resolution/config (jest.config or transform settings) and
update CI; additionally add a short note in README/CONTRIBUTING about required
environment variables and Node/Jest compatibility so contributors can run tests
locally. Locate the "jest" entry in package.json and update dependency or add
documentation and CI fixes accordingly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cfbf9111-0629-4277-bb1d-24746359e9e3

📥 Commits

Reviewing files that changed from the base of the PR and between 03ee528 and 936b84b.

⛔ Files ignored due to path filters (4)
  • dist/index.js is excluded by !**/dist/**
  • dist/index.js.map is excluded by !**/dist/**, !**/*.map
  • dist/licenses.txt is excluded by !**/dist/**
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • .node-version
  • __tests__/wait.test.js
  • action.yml
  • package.json
  • src/main.js
💤 Files with no reviewable changes (1)
  • tests/wait.test.js

Comment thread .node-version Outdated
bro how much water did you drain to make a comment that said that I _need_ to put a ".0" here despite 24.11 being enough (dawg it's a minor version, on an LTS, it's not going to magically explode). I feel with like enough context you'd know this, but you're probably too dumb af.

I'll do it anyways so you'll stop burning down the forests.
@neilenns
Copy link
Copy Markdown
Owner

Thanks, I'll look at this later next week!

@neilenns neilenns merged commit fc7dcc7 into neilenns:main Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants