ci: fix quay login (QUAY_USERNAME is a secret, not a var) - #44
Merged
Merged
Conversation
QUAY_USERNAME is an org secret scoped to public repos, not an Actions variable. The quay login read vars.QUAY_USERNAME (empty), causing 'Username required'. Read it from secrets and declare it as a passed secret so callers forward it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reusable pack-build-image workflow logged into quay with
vars.QUAY_USERNAME, butQUAY_USERNAMEis an org secret (scoped to public repos), not an Actions variable, so it resolved empty and quay login failed withUsername required. Read it fromsecrets.QUAY_USERNAMEand declare it as a passed secret; callers forward it alongsideQUAY_TOKEN. Caught on the first live run of nebari-dev/llm-serving-pack.