Skip to content

Handle IO.select with Float::NAN as timeout #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herwinw wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle IO.select with Float::NAN as timeout #2922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f1eb4
Refresh specs for IO.select
herwinw Feb 5, 2026
04acd30
Handle IO.select with Float::NAN as timeout
herwinw Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion spec/core/io/select_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,17 @@
end

it "raises an ArgumentError when passed a negative timeout" do
-> { IO.select(nil, nil, nil, -5)}.should raise_error(ArgumentError)
-> { IO.select(nil, nil, nil, -5)}.should raise_error(ArgumentError, "time interval must not be negative")
end

ruby_version_is "4.0" do
it "raises an ArgumentError when passed negative infinity as timeout" do
-> { IO.select(nil, nil, nil, -Float::INFINITY)}.should raise_error(ArgumentError, "time interval must not be negative")
end
end

it "raises an RangeError when passed NaN as timeout" do
-> { IO.select(nil, nil, nil, Float::NAN)}.should raise_error(RangeError, "NaN out of Time range")
end

describe "returns the available descriptors when the file descriptor" do
Expand Down
2 changes: 2 additions & 0 deletions src/io_object.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,6 +1107,8 @@ Value IoObject::select(Env *env, Value read_ios, Optional<Value> write_ios, Opti
timeval timeout_tv = { 0, 0 }, *timeout_ptr = nullptr;

if (timeout && !timeout->is_nil() && !(timeout->is_float() && timeout->as_float()->is_positive_infinity())) {
if (timeout->is_float() && timeout->as_float()->is_nan())
env->raise("RangeError", "NaN out of Time range");
const auto timeout_f = timeout->to_f(env)->to_double();
if (timeout_f < 0)
env->raise("ArgumentError", "time interval must not be negative");
Expand Down
Loading