TM::Optional: Run destructor when clearing the value#2860
Open
herwinw wants to merge 4 commits into
Open
Conversation
herwinw
force-pushed
the
optional_placement_new
branch
from
f91a047 to
b3c7f0f
Compare
This is probably a leftover from debugging.
This is done with placement new and manually calling the destructors.
This streamlines the move constructor and move assignment operators by simply copying the bytes instead of calling constructors and destructors.
herwinw
force-pushed
the
optional_placement_new
branch
2 times, most recently
from
789ca48 to
854197e
Compare
herwinw
force-pushed
the
optional_placement_new
branch
from
854197e to
791b16e
Compare
Member
|
Can you write some descriptive text for this? What was the motivation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.