TM::String::format and hex values formatted as float#2858
Merged
Conversation
This test shows the actual behaviour of a float, which should not be truncated silently. Fix this to thrown an error.
Floats should not be silently converted into ints.
Use the _v versions instead of suffixing it with ::value.
herwinw
changed the title
seven1m
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few fixes for
TM::String::formatI found while I was trying to get #2853 to work. I've split these off, and will fix that other case once this is merge.A bit of a cleanup (use the c++14
std::is_pointer_v<T>and similar instead ofstd::is_pointer<T>::value), and don't allow hex printing of floats (these were converted to ints, so the output is not what you would expect, you can still cast them to int manually if you really need the old behaviour).