Skip to content

Add deduplication to Errno objects#2849

Draft
herwinw wants to merge 1 commit into
natalie-lang:masterfrom
herwinw:errno_deduplicate
Draft

Add deduplication to Errno objects#2849
herwinw wants to merge 1 commit into
natalie-lang:masterfrom
herwinw:errno_deduplicate

Conversation

@herwinw
Copy link
Copy Markdown
Member

@herwinw herwinw commented Dec 5, 2025

This makes Errno spec-compliant

This makes Errno spec-compliant
@herwinw
Copy link
Copy Markdown
Member Author

herwinw commented Dec 5, 2025

Since the error messages appear to be removed in the output: it now fails with this:

bin/natalie -I test/support test/natalie/gc_test.rb
.F

Failed specs:
GC
  .enable and .disable
    control automatic garbage collection
      false should be == to true
      (test/natalie/gc_test.rb:44:in 'block in block in block in block')

1 spec(s) passed.
1 spec(s) failed.
0 spec(s) errored.
rake aborted!

So it looks like somehow this change has disabled the garbage collector

@herwinw herwinw marked this pull request as draft December 5, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant