Skip to content

Update move constructor of TM::String #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
herwinw merged 1 commit into from
Jul 12, 2025
+6 −9
Merged

Update move constructor of TM::String #2782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions ext/tm/include/tm/string.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ class String final {
* ```
* auto buf = new char[12];
* strncpy(buf, "hello world", 12);
* auto str = String::create_and_take_ownership(buf, 11);
* auto str = String(std::move(buf), 11);
* assert_eq(11, str.size());
* assert_str_eq("hello world", str);
*
Expand All @@ -258,14 +258,11 @@ class String final {
* str = String {};
* ```
*/
static String create_and_take_ownership(char *buf, const size_t length) {
String result;
auto old_m_str = result.m_str;
result.m_str = buf;
result.m_length = length;
result.m_capacity = length;
delete[] old_m_str;
return result;
String(char *&&str, const size_t length)
: m_str { str }
, m_length { length }
, m_capacity { length } {
assert(str);
}

enum class HexFormat {
Expand Down