Skip to content

Use perfect forwarding for StringObject::create #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herwinw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use perfect forwarding for StringObject::create #2772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 3 additions & 82 deletions include/natalie/string_object.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,89 +39,10 @@ class StringObject : public Object {
Invalid,
};

static StringObject *create(ClassObject *klass) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(klass);
}

static StringObject *create() {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject();
}

static StringObject *create(NonNullPtr<EncodingObject> encoding) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(encoding);
}

static StringObject *create(const char *str) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str);
}

static StringObject *create(const char *str, NonNullPtr<EncodingObject> encoding) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str, encoding);
}

static StringObject *create(const char *str, Encoding encoding) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str, encoding);
}

static StringObject *create(const char *str, size_t length) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str, length);
}

static StringObject *create(const char *str, size_t length, NonNullPtr<EncodingObject> encoding) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str, length, encoding);
}

static StringObject *create(const char *str, size_t length, Encoding encoding) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str, length, encoding);
}

static StringObject *create(const StringObject &other) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(other);
}

static StringObject *create(const String &str) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str);
}

static StringObject *create(String &&str) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(std::move(str));
}

static StringObject *create(const String &str, NonNullPtr<EncodingObject> encoding) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str, encoding);
}

static StringObject *create(String &&str, NonNullPtr<EncodingObject> encoding) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(std::move(str), encoding);
}

static StringObject *create(const String &str, Encoding encoding) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str, encoding);
}

static StringObject *create(String &&str, Encoding encoding) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(std::move(str), encoding);
}

static StringObject *create(const StringView &str, NonNullPtr<EncodingObject> encoding) {
template <typename... Args>
static StringObject *create(Args &&...args) {
std::lock_guard<std::recursive_mutex> lock(g_gc_recursive_mutex);
return new StringObject(str, encoding);
return new StringObject(std::forward<Args>(args)...);
}

const String &string() const { return m_string; }
Expand Down
Loading