Add data recording support for STL (vector, deque, and array) of supported data types.#2154
Open
hchen99 wants to merge 5 commits into
Open
Add data recording support for STL (vector, deque, and array) of supported data types.#2154hchen99 wants to merge 5 commits into
hchen99 wants to merge 5 commits into
Conversation
|
coverage: 56.247% (+0.1%) from 56.126% — stl_data_record into master |
Comment on lines
346
to
348
Contributor
There was a problem hiding this comment.
this if check was and still isn't reachable?
Contributor
Author
There was a problem hiding this comment.
yea, should be outside of switch statement ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add data recording support for STL (vector, deque, and array) of supported data types.
No .h5 file comparison for the test due to HDF5 files generated by DRHDF5.cpp embeds timestamps. md5sum comparison would fail on each run.