Skip to content

ci: Adopt orchestrator + reusable-workflow model and improve test reporting #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brendan-nasa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: Adopt orchestrator + reusable-workflow model and improve test reporting #2142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions .github/workflows/_code-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# Reusable workflow: code coverage build + Coveralls upload.
# Called by ci.yml. Do not add push/pull_request triggers here.
name: Code Coverage

on:
workflow_call:

permissions:
contents: read

jobs:
code-coverage:
name: lcov + Coveralls
runs-on: ubuntu-latest
env:
CFLAGS: "-fprofile-arcs -ftest-coverage -fprofile-update=atomic -O0"
CXXFLAGS: "-fprofile-arcs -ftest-coverage -fprofile-update=atomic -O0"
LDFLAGS: "-fprofile-arcs -ftest-coverage -O0"
TRICK_CFLAGS: "-fprofile-arcs -ftest-coverage -fprofile-update=atomic -O0"
TRICK_CXXFLAGS: "-fprofile-arcs -ftest-coverage -fprofile-update=atomic -O0"
TRICK_SYSTEM_LDFLAGS: "-fprofile-arcs -ftest-coverage -O0"
TRICK_SYSTEM_CFLAGS: "-fprofile-arcs -ftest-coverage -fprofile-update=atomic -O0"
TRICK_SYSTEM_CXXFLAGS: "-fprofile-arcs -ftest-coverage -fprofile-update=atomic -O0"
steps:
- name: Install Dependencies
run: |
sudo apt-get update -qq
sudo apt-get install -y \
bison clang flex git llvm make maven cmake zip \
g++ libclang-dev llvm-dev \
default-jdk libxml2-dev libmotif-dev libxt-dev \
perl libdigest-md5-perl libudunits2-dev zlib1g-dev \
python3-dev python3-pip python3-venv swig \
libgtest-dev libgmock-dev lcov
- name: Checkout repository
uses: actions/checkout@v7
- name: Configure Trick
run: |
echo "MAKEFLAGS=-j$(nproc)" >> "$GITHUB_ENV"
echo "JAVA_HOME=$(dirname $(dirname $(readlink -f $(which java))))" >> "$GITHUB_ENV"
./configure
- name: Build Trick
run: make
- name: Generate Code Coverage
run: |
python3 -m venv share/trick/trickops/.venv
. share/trick/trickops/.venv/bin/activate
pip3 install -r share/trick/trickops/requirements.txt
make code-coverage
- name: Upload to Coveralls
uses: coverallsapp/github-action@v2
continue-on-error: true
with:
file: coverage.info
format: lcov
205 changes: 205 additions & 0 deletions .github/workflows/_style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,205 @@
# Reusable workflow: style / format checks.
# Called by ci.yml. Do not add push/pull_request triggers here.
name: Style Checks

on:
workflow_call:

permissions:
contents: read

jobs:
style:
name: Style Check
runs-on: ubuntu-26.04
steps:
- name: Checkout repository
uses: actions/checkout@v7
with:
fetch-depth: 0

- name: Install tools
run: |
sudo apt-get update -qq
sudo apt-get install -y clang-format cpanminus pipx maven
sudo cpanm --notest Perl::Tidy
pipx install ruff
echo "$HOME/.local/bin" >> "$GITHUB_PATH"

- name: Check clang-format on changed C/C++ lines
if: ${{ !cancelled() }}
run: |
set -euo pipefail

if [ "${{ github.event_name }}" = "pull_request" ]; then
BASE=${{ github.event.pull_request.base.sha }}
else
git fetch origin master
BASE=$(git merge-base origin/master HEAD)
fi

DIFF=$(git clang-format --diff "$BASE" --extensions c,h,cpp,hpp,cc,hh) || true

if echo "$DIFF" | grep -q '^diff'; then
echo "$DIFF"
echo ""
echo "::error::Changed lines are not correctly formatted."
echo "::error::To fix, run: git clang-format ${{ github.base_ref || 'master' }}"
exit 1
fi
echo "All changed C/C++ lines are correctly formatted."

- name: Check perltidy on changed Perl files
if: ${{ !cancelled() }}
run: |
set -euo pipefail

if [ "${{ github.event_name }}" = "pull_request" ]; then
BASE=${{ github.event.pull_request.base.sha }}
else
git fetch origin master
BASE=$(git merge-base origin/master HEAD)
fi

# Collect changed Perl files: by extension and by shebang
PERL_FILES=()
while IFS= read -r f; do
[ -z "$f" ] && continue
case "$f" in
*.pl|*.pm|*.t) PERL_FILES+=("$f") ;;
*) if head -1 "$f" 2>/dev/null | grep -q '^#!.*perl'; then
PERL_FILES+=("$f")
fi ;;
esac
done < <(git diff --diff-filter=ACMR --name-only "$BASE")

if [ ${#PERL_FILES[@]} -eq 0 ]; then
echo "No changed Perl files to check."
exit 0
fi

FAILED=0
for f in "${PERL_FILES[@]}"; do
if ! perltidy -st -se -nb "$f" | diff -u "$f" -; then
echo "::error file=$f::$f is not perltidy-compliant."
FAILED=1
fi
done

if [ $FAILED -ne 0 ]; then
echo ""
echo "::error::To fix, run: perltidy -b <file>"
exit 1
fi
echo "All changed Perl files are correctly formatted."

- name: Check ruff formatting on changed Python files
if: ${{ !cancelled() }}
run: |
set -euo pipefail

if [ "${{ github.event_name }}" = "pull_request" ]; then
BASE=${{ github.event.pull_request.base.sha }}
else
git fetch origin master
BASE=$(git merge-base origin/master HEAD)
fi

# Collect changed Python files: by extension and by shebang
PYTHON_FILES=()
while IFS= read -r f; do
[ -z "$f" ] && continue
case "$f" in
*.py) PYTHON_FILES+=("$f") ;;
*) if head -1 "$f" 2>/dev/null | grep -q '^#!.*python'; then
PYTHON_FILES+=("$f")
fi ;;
esac
done < <(git diff --diff-filter=ACMR --name-only "$BASE")

if [ ${#PYTHON_FILES[@]} -eq 0 ]; then
echo "No changed Python files to check."
exit 0
fi

FAILED=0
for f in "${PYTHON_FILES[@]}"; do
if ! ruff format --preview --check --diff "$f"; then
echo "::error file=$f::$f is not ruff-formatted."
FAILED=1
fi
if ! ruff check --preview --select I --diff "$f"; then
echo "::error file=$f::$f has unsorted imports."
FAILED=1
fi
done

if [ $FAILED -ne 0 ]; then
echo ""
echo "::error::Changed Python files have formatting or import issues."
echo "::error::To fix, run: ruff check --preview --select I --fix <file> && ruff format --preview <file>"
exit 1
fi
echo "All changed Python files are correctly formatted."

- name: Check spotless on changed Java files
if: ${{ !cancelled() }}
run: |
set -euo pipefail

if [ "${{ github.event_name }}" = "pull_request" ]; then
BASE=${{ github.event.pull_request.base.sha }}
else
git fetch origin master
BASE=$(git merge-base origin/master HEAD)
fi

JAVA_FILES=$(git diff --diff-filter=ACMR --name-only "$BASE" | grep '\.java$' || true)

if [ -z "$JAVA_FILES" ]; then
echo "No changed Java files to check."
exit 0
fi

echo "Changed Java files:"
echo "$JAVA_FILES"

if ! mvn -f trick_source/java/pom.xml --batch-mode -q spotless:check; then
echo ""
echo "::error::Changed Java files are not correctly formatted."
echo "::error::To fix, run: mvn -f trick_source/java/pom.xml spotless:apply"
exit 1
fi
echo "All changed Java files are correctly formatted."

# TODO: Once the codebase is fully formatted, switch to whole-file checking:
#
# - name: Check formatting of changed files
# id: clang_format
# continue-on-error: true
# run: |
# set -euo pipefail
#
# if [ "${{ github.event_name }}" = "pull_request" ]; then
# BASE=${{ github.event.pull_request.base.sha }}
# else
# git fetch origin master
# BASE=$(git merge-base origin/master HEAD)
# fi
#
# FAILED=0
# while IFS= read -r f; do
# [ -z "$f" ] && continue
# if ! clang-format -n --Werror --style=file "$f"; then
# echo "::error file=$f::$f is not correctly formatted."
# FAILED=1
# fi
# done < <(git diff --diff-filter=ACMR --name-only "$BASE" -- \
# '*.[hc]pp' '*.cc' '*.[ch]' '*.hh')
#
# if [ $FAILED -ne 0 ]; then
# echo ""
# echo "::error::To fix, run: clang-format -i --style=file <file>"
# exit 1
# fi
# echo "All changed C/C++ files are correctly formatted."
Loading
Loading