Skip to content

Generate parameterUpdated calls in parametersLoaded #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
durasi wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Generate parameterUpdated calls in parametersLoaded #1097

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30ff847
Generate parameterUpdated calls in parametersLoaded (#5697)
durasi Sep 3, 2026
1802ae8
Guard parameterUpdated calls in parametersLoaded with validity check
durasi Sep 8, 2026
ed7513c
Add parameterLoaded hook called as each parameter is loaded
durasi Sep 8, 2026
769faa3
Apply review suggestions: guardedList for include, rename hook
durasi Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentParameters.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,18 @@ case class ComponentParameters (
Some(
s"""|\\brief Called whenever parameters are loaded
|
|This function does nothing by default. You may override it.
|By default this notifies the component of each parameter via
|parameterUpdated. You may override it, for example to suppress
|notification on load.
|"""
),
"parametersLoaded",
Nil,
CppDoc.Type("void"),
lines("// Do nothing by default"),
if sortedParams.isEmpty then lines("// No parameters")
Comment thread
bocchino marked this conversation as resolved.
Outdated
else sortedParams.flatMap((_, param) =>
lines(s"this->parameterUpdated(${paramIdConstantName(param.getName)});")
),
CppDoc.Function.Virtual
)

Expand Down
7 changes: 6 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/ActiveExternalParamsComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3492,7 +3492,12 @@ void ActiveExternalParamsComponentBase ::
void ActiveExternalParamsComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMI32EXT);
Comment thread
bocchino marked this conversation as resolved.
Outdated
this->parameterUpdated(PARAMID_PARAMF64EXT);
this->parameterUpdated(PARAMID_PARAMSTRINGEXT);
this->parameterUpdated(PARAMID_PARAMENUMEXT);
this->parameterUpdated(PARAMID_PARAMARRAYEXT);
this->parameterUpdated(PARAMID_PARAMSTRUCTEXT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/ActiveExternalParamsComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,7 +1544,9 @@ class ActiveExternalParamsComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
7 changes: 6 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/ActiveParamsComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3438,7 +3438,12 @@ void ActiveParamsComponentBase ::
void ActiveParamsComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMU32);
this->parameterUpdated(PARAMID_PARAMF64);
this->parameterUpdated(PARAMID_PARAMSTRING);
this->parameterUpdated(PARAMID_PARAMENUM);
this->parameterUpdated(PARAMID_PARAMARRAY);
this->parameterUpdated(PARAMID_PARAMSTRUCT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/ActiveParamsComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1543,7 +1543,9 @@ class ActiveParamsComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
13 changes: 12 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/ActiveSerialComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7117,7 +7117,18 @@ void ActiveSerialComponentBase ::
void ActiveSerialComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMU32);
this->parameterUpdated(PARAMID_PARAMF64);
this->parameterUpdated(PARAMID_PARAMSTRING);
this->parameterUpdated(PARAMID_PARAMENUM);
this->parameterUpdated(PARAMID_PARAMARRAY);
this->parameterUpdated(PARAMID_PARAMSTRUCT);
this->parameterUpdated(PARAMID_PARAMI32EXT);
this->parameterUpdated(PARAMID_PARAMF64EXT);
this->parameterUpdated(PARAMID_PARAMSTRINGEXT);
this->parameterUpdated(PARAMID_PARAMENUMEXT);
this->parameterUpdated(PARAMID_PARAMARRAYEXT);
this->parameterUpdated(PARAMID_PARAMSTRUCTEXT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/ActiveSerialComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2550,7 +2550,9 @@ class ActiveSerialComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
13 changes: 12 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/ActiveTestComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6949,7 +6949,18 @@ namespace M {
void ActiveTestComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMU32);
this->parameterUpdated(PARAMID_PARAMF64);
this->parameterUpdated(PARAMID_PARAMSTRING);
this->parameterUpdated(PARAMID_PARAMENUM);
this->parameterUpdated(PARAMID_PARAMARRAY);
this->parameterUpdated(PARAMID_PARAMSTRUCT);
this->parameterUpdated(PARAMID_PARAMI32EXT);
this->parameterUpdated(PARAMID_PARAMF64EXT);
this->parameterUpdated(PARAMID_PARAMSTRINGEXT);
this->parameterUpdated(PARAMID_PARAMENUMEXT);
this->parameterUpdated(PARAMID_PARAMARRAYEXT);
this->parameterUpdated(PARAMID_PARAMSTRUCTEXT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/ActiveTestComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2490,7 +2490,9 @@ namespace M {

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
7 changes: 6 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/PassiveExternalParamsComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2538,7 +2538,12 @@ void PassiveExternalParamsComponentBase ::
void PassiveExternalParamsComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMI32EXT);
this->parameterUpdated(PARAMID_PARAMF64EXT);
this->parameterUpdated(PARAMID_PARAMSTRINGEXT);
this->parameterUpdated(PARAMID_PARAMENUMEXT);
this->parameterUpdated(PARAMID_PARAMARRAYEXT);
this->parameterUpdated(PARAMID_PARAMSTRUCTEXT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/PassiveExternalParamsComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,9 @@ class PassiveExternalParamsComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
7 changes: 6 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/PassiveParamsComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2484,7 +2484,12 @@ void PassiveParamsComponentBase ::
void PassiveParamsComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMU32);
this->parameterUpdated(PARAMID_PARAMF64);
this->parameterUpdated(PARAMID_PARAMSTRING);
this->parameterUpdated(PARAMID_PARAMENUM);
this->parameterUpdated(PARAMID_PARAMARRAY);
this->parameterUpdated(PARAMID_PARAMSTRUCT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/PassiveParamsComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,9 @@ class PassiveParamsComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
13 changes: 12 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/PassiveSerialComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5023,7 +5023,18 @@ void PassiveSerialComponentBase ::
void PassiveSerialComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMU32);
this->parameterUpdated(PARAMID_PARAMF64);
this->parameterUpdated(PARAMID_PARAMSTRING);
this->parameterUpdated(PARAMID_PARAMENUM);
this->parameterUpdated(PARAMID_PARAMARRAY);
this->parameterUpdated(PARAMID_PARAMSTRUCT);
this->parameterUpdated(PARAMID_PARAMI32EXT);
this->parameterUpdated(PARAMID_PARAMF64EXT);
this->parameterUpdated(PARAMID_PARAMSTRINGEXT);
this->parameterUpdated(PARAMID_PARAMENUMEXT);
this->parameterUpdated(PARAMID_PARAMARRAYEXT);
this->parameterUpdated(PARAMID_PARAMSTRUCTEXT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/PassiveSerialComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1904,7 +1904,9 @@ class PassiveSerialComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
13 changes: 12 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/PassiveTestComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5203,7 +5203,18 @@ void PassiveTestComponentBase ::
void PassiveTestComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMU32);
this->parameterUpdated(PARAMID_PARAMF64);
this->parameterUpdated(PARAMID_PARAMSTRING);
this->parameterUpdated(PARAMID_PARAMENUM);
this->parameterUpdated(PARAMID_PARAMARRAY);
this->parameterUpdated(PARAMID_PARAMSTRUCT);
this->parameterUpdated(PARAMID_PARAMI32EXT);
this->parameterUpdated(PARAMID_PARAMF64EXT);
this->parameterUpdated(PARAMID_PARAMSTRINGEXT);
this->parameterUpdated(PARAMID_PARAMENUMEXT);
this->parameterUpdated(PARAMID_PARAMARRAYEXT);
this->parameterUpdated(PARAMID_PARAMSTRUCTEXT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/PassiveTestComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1967,7 +1967,9 @@ class PassiveTestComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
7 changes: 6 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/QueuedExternalParamsComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3492,7 +3492,12 @@ void QueuedExternalParamsComponentBase ::
void QueuedExternalParamsComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMI32EXT);
this->parameterUpdated(PARAMID_PARAMF64EXT);
this->parameterUpdated(PARAMID_PARAMSTRINGEXT);
this->parameterUpdated(PARAMID_PARAMENUMEXT);
this->parameterUpdated(PARAMID_PARAMARRAYEXT);
this->parameterUpdated(PARAMID_PARAMSTRUCTEXT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/QueuedExternalParamsComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,7 +1544,9 @@ class QueuedExternalParamsComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
7 changes: 6 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/QueuedParamsComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3438,7 +3438,12 @@ void QueuedParamsComponentBase ::
void QueuedParamsComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMU32);
this->parameterUpdated(PARAMID_PARAMF64);
this->parameterUpdated(PARAMID_PARAMSTRING);
this->parameterUpdated(PARAMID_PARAMENUM);
this->parameterUpdated(PARAMID_PARAMARRAY);
this->parameterUpdated(PARAMID_PARAMSTRUCT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/QueuedParamsComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1543,7 +1543,9 @@ class QueuedParamsComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
13 changes: 12 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/QueuedSerialComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7117,7 +7117,18 @@ void QueuedSerialComponentBase ::
void QueuedSerialComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMU32);
this->parameterUpdated(PARAMID_PARAMF64);
this->parameterUpdated(PARAMID_PARAMSTRING);
this->parameterUpdated(PARAMID_PARAMENUM);
this->parameterUpdated(PARAMID_PARAMARRAY);
this->parameterUpdated(PARAMID_PARAMSTRUCT);
this->parameterUpdated(PARAMID_PARAMI32EXT);
this->parameterUpdated(PARAMID_PARAMF64EXT);
this->parameterUpdated(PARAMID_PARAMSTRINGEXT);
this->parameterUpdated(PARAMID_PARAMENUMEXT);
this->parameterUpdated(PARAMID_PARAMARRAYEXT);
this->parameterUpdated(PARAMID_PARAMSTRUCTEXT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/QueuedSerialComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2550,7 +2550,9 @@ class QueuedSerialComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down
13 changes: 12 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/QueuedTestComponentAc.ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6947,7 +6947,18 @@ void QueuedTestComponentBase ::
void QueuedTestComponentBase ::
parametersLoaded()
{
// Do nothing by default
this->parameterUpdated(PARAMID_PARAMU32);
this->parameterUpdated(PARAMID_PARAMF64);
this->parameterUpdated(PARAMID_PARAMSTRING);
this->parameterUpdated(PARAMID_PARAMENUM);
this->parameterUpdated(PARAMID_PARAMARRAY);
this->parameterUpdated(PARAMID_PARAMSTRUCT);
this->parameterUpdated(PARAMID_PARAMI32EXT);
this->parameterUpdated(PARAMID_PARAMF64EXT);
this->parameterUpdated(PARAMID_PARAMSTRINGEXT);
this->parameterUpdated(PARAMID_PARAMENUMEXT);
this->parameterUpdated(PARAMID_PARAMARRAYEXT);
this->parameterUpdated(PARAMID_PARAMSTRUCTEXT);
}

// ----------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion compiler/tools/fpp-to-cpp/test/component/base/QueuedTestComponentAc.ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2488,7 +2488,9 @@ class QueuedTestComponentBase :

//! \brief Called whenever parameters are loaded
//!
//! This function does nothing by default. You may override it.
//! By default this notifies the component of each parameter via
//! parameterUpdated. You may override it, for example to suppress
//! notification on load.
virtual void parametersLoaded();

protected:
Expand Down