Skip to content

Pin published wheel version to the release tag via SETUPTOOLS_SCM_PRETEND_VERSION - #1076

Open
LeStarch wants to merge 1 commit into
nasa:mainfrom
JPL-Devin:devin/1787167307-release-tag-version
Open

Pin published wheel version to the release tag via SETUPTOOLS_SCM_PRETEND_VERSION#1076
LeStarch wants to merge 1 commit into
nasa:mainfrom
JPL-Devin:devin/1787167307-release-tag-version

Conversation

@LeStarch

Copy link
Copy Markdown
Collaborator

This PR solves the issue where publishing the same release with two tags may pick the wrong PIP version for our python packages. This solves it by supplying an explicit version keyed to the release supplied by the CI system.

…TEND_VERSION

Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>

@bocchino bocchino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by inspection. I have not attempted to verify that it is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants