Skip to content

docker: Add make install in Dockerfile when test=yes#1787

Open
3godhalmang wants to merge 1 commit intonamhyung:masterfrom
3godhalmang:docker_file
Open

docker: Add make install in Dockerfile when test=yes#1787
3godhalmang wants to merge 1 commit intonamhyung:masterfrom
3godhalmang:docker_file

Conversation

@3godhalmang
Copy link
Copy Markdown

Added code because docker file is missing 'make install' in case test=yes

Alpine and Arch could not be added due to the following error
I'm going to give a try to fix these problems.

Alpine(only if test =yes)
[Makefile:49: test_unit] Segmentation fault (core dumped)

Arch(for both condition)
no matching manifest for linux/arm64/v8 in the manifest list entries

Added code because docker file is missing 'make install' in case test=yes

Signed-off-by: Sungho Park <powdownow@gmail.com>
@namhyung
Copy link
Copy Markdown
Owner

It seems the failure in Alpine is not related to make install. Also I'm not sure if we really want to run make install for tests.

@3godhalmang
Copy link
Copy Markdown
Author

It would be better to include the make install process for tests
because there was a make install fail problem with PANDOC in 2.0 and earlier.

related: #1766, #1783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants