chore: remove dead FetchWorkspaceRequirements function - #1935
Open
detail-app[bot] wants to merge 1 commit into
Open
chore: remove dead FetchWorkspaceRequirements function#1935detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed FetchWorkspaceRequirements from internal/cli/versioncheck/fetch.go, along with its now-unused cuefrontend and schema imports.
FetchWorkspaceRequirements had zero callers anywhere in the codebase. The function lived under an internal/ package (so no external consumer could exist), and its sole intended consumer — a computeRequirements callback parameter on CheckRemote — was removed in commit 28cbca9, leaving this helper orphaned. The function was self-described as broken (an 'XXX this method is not correct' comment) and nothing has wired it back in since.
History
Dead Code PRs can be configured here.