chore: remove dead UserAuth fields and StoreMarshalledUser - #1923
Open
detail-app[bot] wants to merge 1 commit into
Open
chore: remove dead UserAuth fields and StoreMarshalledUser#1923detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the unused StoreMarshalledUser function and the Org,
InternalOpaque, Clerk, and IsGithubAction fields from the UserAuth
struct, along with the now-unused context and clerk imports.
These symbols were left behind after commit f152d3d ("auth: remove
dead code.", Oct 2023) removed their last readers and callers (the
StoreUser, GenerateToken/GenerateTokenFromUserAuth, clerk login path,
and GitHub Actions login path). The modern login flow uses tenant
tokens via tokens.go (token.json) instead of auth.json. None of these
fields are read or written anywhere in production code; only Username
remains in use (read by the ns doctor diagnostic at doctor.go:170).
History
Dead Code PRs can be configured here.